fix: Patch inline image breaking images when server does not support CORS#13
Draft
fix: Patch inline image breaking images when server does not support CORS#13
Conversation
Image quality should be controllable via `dataURLOptions`.
📦 Changeset Status |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an issue where rrweb would retry inlining images by setting the
crossorigin='anonymous'attribute on the image. This causes the browser to refetch the image, and if the server does not support CORS, it'll cause the image to not render because CORS error will not trigger the cleanup/restore logic.In this PR, we are basing our solution on this proposed fix: valenfv-felix@11debf2. It ensures we adhere to using the canvas to generate the image data url, with tie-ins to rrweb's
dataURLOptionssetting to control the quality of the image.https://new-relic.atlassian.net/browse/NR-519763