ci: updated workflows for pull request and merge to main #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voorepreethi
requested review from
maya-jha,
sanathramesh,
hrai-nr,
nr-rkallempudi,
ahegdeNR,
AkhilReddyS-NR,
rohit-bandlamudi-nr and
gunnalahema
hrai-nr
previously approved these changes
Nov 7, 2024
maya-jha
requested changes
Nov 8, 2024
.github/workflows/release.yaml
Outdated
| @@ -0,0 +1,35 @@ | |||
| name: Build and Deploy Lambda | |||
.github/workflows/pull_request.yaml
Outdated
| - name: Validate SAM Templates | ||
| run: | | ||
| for template in $(find . -name ".yaml" -o -name ".yml"); do | ||
| echo "Validating template: $template" |
There was a problem hiding this comment.
I don't see this getting logged, where can I see it.
| run: sam build --template-file firehose-template.yaml --region us-east-2 | ||
|
|
||
| - name: Package SAM Application | ||
| run: sam package --s3-bucket unified-lambda-cft-1 --output-template-file firehose-template.yaml --region us-east-2 |
There was a problem hiding this comment.
why this bucket? unified-lambda-cft-1?
There was a problem hiding this comment.
Yes. Since same bucket name cannot be created across different accounts as well , I put it unified-lambda-serverless-1. The original bucket is unified-lambda-serverless.
| run: sam package --s3-bucket unified-lambda-cft-1 --output-template-file firehose-template.yaml --region us-east-2 | ||
|
|
||
| - name: Upload CloudFormation Template to S3 | ||
| run: aws s3 cp firehose-template.yaml s3://unified-lambda-serverless-1/firehose-template.yaml |
There was a problem hiding this comment.
this is not the prod bucket. Are you planning to change it?
There was a problem hiding this comment.
Yes. Once we move to Jim Rupert, would change
|
validate sam template is failing, please look into this. |
maya-jha
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of workflows for pull request and release.
Pull Request workflow consists of:
a. Installing sam cli.
b. Validating all the templates using sam.
Release workflow consists of :
a. Install sam cli.
b. Build, package and publishing the template file to s3 bucket.