-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E test cases for firehose #16
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Please make e2e tests mandatory only for merges and not pull requests. To fix this create different rule sets for develop and main branch instead of clubbing them. And add e2e tests as mandatory step only for main. Approved
how did you test this? |
To test this, I am creating the PR with :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validate whether tests are run before merging or after merging.
This PR is raised for validating end to end test cases for firehose. Here are the cases we are validating: