Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E test cases for firehose #16

Open
wants to merge 32 commits into
base: develop
Choose a base branch
from
Open

E2E test cases for firehose #16

wants to merge 32 commits into from

Conversation

hrai-nr
Copy link
Contributor

@hrai-nr hrai-nr commented Jan 4, 2025

This PR is raised for validating end to end test cases for firehose. Here are the cases we are validating:

  1. Firehose stack is deployed with single cloudwatch trigger. Created a log event and validated that logs are flowing to New Relic successfully.
  2. Firehose is deployed with single cloudwatch trigger with filter pattern present. Then validated the below 2 cases:
  • When data is added with the filter pattern firehose reads that data and pushes to New Relic. Validated that the log exist in new Relic
  • When data is added without the filter pattern firehose doesn’t push anything to New Relic. Validated that the log does not exist in new Relic
  1. Firehose is deployed with single cloudwatch trigger with invalid cloudwatch log group name. Validate that cloudwatch trigger is not created. But firehose stack and firehose delivery stream is created.
  2. For the logs that are flown in NewRelic we are validating common attributes as well as entity synthesis parameters.

@hrai-nr hrai-nr changed the base branch from main to develop January 13, 2025 10:19
@hrai-nr hrai-nr requested a review from maya-jha January 15, 2025 08:39
.github/workflows/run-e2e-tests.yaml Outdated Show resolved Hide resolved
.github/workflows/run-e2e-tests.yaml Outdated Show resolved Hide resolved
.github/workflows/run-e2e-tests.yaml Show resolved Hide resolved
e2e_tests/common-scripts.sh Show resolved Hide resolved
e2e_tests/common-scripts.sh Show resolved Hide resolved
e2e_tests/common-scripts.sh Outdated Show resolved Hide resolved
e2e_tests/firehose_e2e_tests.sh Outdated Show resolved Hide resolved
e2e_tests/firehose_e2e_tests.sh Show resolved Hide resolved
.github/workflows/run-e2e-tests.yaml Outdated Show resolved Hide resolved
.github/workflows/run-e2e-tests.yaml Outdated Show resolved Hide resolved
@hrai-nr hrai-nr requested a review from ahegdeNR January 16, 2025 07:44
ahegdeNR
ahegdeNR previously approved these changes Jan 16, 2025
Copy link
Contributor

@ahegdeNR ahegdeNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Please make e2e tests mandatory only for merges and not pull requests. To fix this create different rule sets for develop and main branch instead of clubbing them. And add e2e tests as mandatory step only for main. Approved

e2e_tests/firehose_e2e_tests.sh Show resolved Hide resolved
e2e_tests/common-scripts.sh Outdated Show resolved Hide resolved
e2e_tests/config-file.cfg Outdated Show resolved Hide resolved
e2e_tests/common-scripts.sh Outdated Show resolved Hide resolved
e2e_tests/common-scripts.sh Outdated Show resolved Hide resolved
e2e_tests/common-scripts.sh Outdated Show resolved Hide resolved
.github/workflows/run-e2e-tests.yaml Show resolved Hide resolved
e2e_tests/common-scripts.sh Outdated Show resolved Hide resolved
e2e_tests/firehose_e2e_tests.sh Outdated Show resolved Hide resolved
e2e_tests/firehose_e2e_tests.sh Show resolved Hide resolved
@hrai-nr hrai-nr requested review from ahegdeNR and maya-jha January 19, 2025 16:03
e2e_tests/entity_synthesis_param.cfg Show resolved Hide resolved
e2e_tests/common-scripts.sh Show resolved Hide resolved
@maya-jha
Copy link

how did you test this?

e2e_tests/entity_synthesis_param.cfg Outdated Show resolved Hide resolved
e2e_tests/firehose_e2e_tests.sh Outdated Show resolved Hide resolved
e2e_tests/firehose_e2e_tests.sh Outdated Show resolved Hide resolved
e2e_tests/common-scripts.sh Outdated Show resolved Hide resolved
@hrai-nr
Copy link
Contributor Author

hrai-nr commented Jan 21, 2025

how did you test this?

To test this, I am creating the PR with :
on:
pull_request:
branches:
- main
- develop

  and then once everything is working fine adding one more commit to change the  pull_request to push

Copy link

@maya-jha maya-jha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validate whether tests are run before merging or after merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants