Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated and added parameters for entity synthesis #2

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

voorepreethi
Copy link
Contributor

This PR consists of addition of intrumentation version and also aws parameter changes .
Reference: https://newrelic.atlassian.net/wiki/spaces/TDP/pages/3844505926/Naming+of+attributes+added+for+AWS+entity+synthesis+out+of+logs

@voorepreethi voorepreethi requested a review from maya-jha November 7, 2024 10:08
{"AttributeName": "awsAccountId", "AttributeValue": account_id},
{"AttributeName": "awsRegion", "AttributeValue": region },
{"AttributeName": "aws.accountId", "AttributeValue": account_id},
{"AttributeName": "aws.region", "AttributeValue": region },
{"AttributeName": "instrumentation.provider", "AttributeValue": "nr-aws"},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it going to be aws or nr-aws? Maybe add Josep as reviewer too.

@voorepreethi voorepreethi requested a review from jsubirat November 7, 2024 16:50
{"AttributeName": "awsRegion", "AttributeValue": region },
{"AttributeName": "instrumentation.provider", "AttributeValue": "nr-aws"},
{"AttributeName": "aws.accountId", "AttributeValue": account_id},
{"AttributeName": "aws.region", "AttributeValue": region },

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra space after region.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@hrai-nr hrai-nr merged commit 26a1823 into main Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants