Add reusable pipeline for publishing OHI to New Relic Control catalog#192
Add reusable pipeline for publishing OHI to New Relic Control catalog#192jcoscollanr wants to merge 3 commits into
Conversation
sairaj18
left a comment
sairaj18
left a comment
There was a problem hiding this comment.
Thanks for working on this change, left few comments.
| echo "EOF" | ||
| } >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Resolve metadata git ref |
There was a problem hiding this comment.
Nit: This step is missing set -euo pipefail that every other run block has
| echo "ref=${REF:-${{ steps.validate.outputs.tag }}}" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Upload to Agent Metadata | ||
| uses: newrelic/agent-metadata-action@main |
There was a problem hiding this comment.
Instead of referring main can we use a released tag or commit. This will make sure downstream change to the action doesn't change how every OHI publishes.
| oci-registry: ${{ inputs.oci_registry }} | ||
| oci-username: ${{ secrets.OCI_USERNAME }} | ||
| oci-password: ${{ secrets.OCI_PASSWORD }} | ||
| apm-control-nr-license-key: ${{ secrets.APM_CONTROL_NR_LICENSE_KEY_STAGING }} |
There was a problem hiding this comment.
We are using APM_CONTROL_NR_LICENSE_KEY_STAGING i.e a staging license key, Is it because we are adding agent-control OHI support only for staging as of now?
There was a problem hiding this comment.
No, the github action is a go binary. and it's instrumented so if there are errors we can receive alerts etc...
This is env variable is just the license key
2 participants
Why
Clients can use new relic control, to install and manage agents in their infrastructure. We have already NRInfra, NRDot and some more.
We are working now on giving support for OHI's. So clients can manage their redis,postgresql etc... and push configuration changes through the agent control.
What
This PR gives a generic pipeline for other repos to call that:
Notes
source_repoandmetadata_git_refare there since I did this PR from a fork and for testing puposes.