Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add steps to see relationship between Otel Service and AWS Memcached #19846

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

Sanjalee-NewRelic
Copy link

@Sanjalee-NewRelic Sanjalee-NewRelic commented Jan 30, 2025

Please follow conventional commit standards
in your commit messages and pull request title.

Give us some context

  • What problems does this PR solve?
    Updated the opentelemetry resources with the information on how to see relationship between an opentelemetry instrumented service and AWS memcached cluster
  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.
986564dc-6dc4-4ed8-becd-9bb2be840f08

@Sanjalee-NewRelic Sanjalee-NewRelic requested a review from a team as a code owner January 30, 2025 08:37
@CLAassistant
Copy link

CLAassistant commented Jan 30, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

Hi @Sanjalee-NewRelic 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit e1ef691
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/679c642d75f6fc0008588ef2
😎 Deploy Preview https://deploy-preview-19846--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sanjalee-NewRelic Sanjalee-NewRelic changed the title Update otel aws relatiionship docs Add steps to see relationship between Otel Service and AWS Memcached Jan 30, 2025
Comment on lines +145 to +148
The memcacahed cluster entity to which the service is connecting should have the following tags:

* `aws.elasticache.configurationEndpointAddress` or `aws.elasticache.endpointAddress`: AWS connection endpoint of the memcached cluster matching with the span attribute `net.peer.name` of the service.
* `aws.elasticache.configurationEndpointPort` or `aws.elasticache.endpointPort`: Port number on which memcached cluster is running matching with the span attribute `net.peer.port` of the service.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do these tags come from? Does this require using a New Relic specific integration for AWS?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alanwest These tags are shown if the provider account in AWS integrations has metric streams enabled instead of API polling.

Comment on lines 141 to 142
* `net.peer.name`: AWS connection endpoint of the memcached clusterr ending with `cache.amazonaws.com`
* `net.peer.port`: Port number on which memcached cluster is running eg: `11211`
Copy link
Member

@alanwest alanwest Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

net.peer.name and net.peer.port are old attributes and they have been deprecated. There is probably still old instrumentation that produces them, but we're going to need to support the new attributes.

@jack-berg we should consider basing this rule on the apm.service.datastore.operation metric we generate. That way our entity relationship definitions do not need to support evolving semantic conventions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See slack convo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants