Update regex for ARN in _Explicit relationships (#1948)

* fix: Update regex for ARN in _Explicit relationships * fix: Correct regex for MSK arn * fix: Add the uninstrumented entities on miss
newrelic · Feb 24, 2025 · 7e89316 · 7e89316
1 parent 48ac461
commit 7e89316
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 6 deletions.
diff --git a/relationships/candidates/AWSELASTICSEARCHCLUSTER_EXPLICIT.yml b/relationships/candidates/AWSELASTICSEARCHCLUSTER_EXPLICIT.yml
@@ -11,4 +11,6 @@ lookups:
     onMatch:
       onMultipleMatches: RELATE_ALL
     onMiss:
-      action: NO_OP
+      action: CREATE_UNINSTRUMENTED
+      uninstrumented:
+        type: AWSELASTICSEARCHCLUSTER
diff --git a/relationships/candidates/AWSMQBROKER_EXPLICIT.yml b/relationships/candidates/AWSMQBROKER_EXPLICIT.yml
@@ -11,4 +11,6 @@ lookups:
     onMatch:
       onMultipleMatches: RELATE_ALL
     onMiss:
-      action: NO_OP
+      action: CREATE_UNINSTRUMENTED
+      uninstrumented:
+        type: MQBROKER
diff --git a/relationships/candidates/KAFKATOPIC_EXPLICIT.yml b/relationships/candidates/KAFKATOPIC_EXPLICIT.yml
@@ -11,4 +11,6 @@ lookups:
     onMatch:
      onMultipleMatches: RELATE_ALL
     onMiss:
-      action: NO_OP
+      action: CREATE_UNINSTRUMENTED
+      uninstrumented:
+        type: KAFKATOPIC
diff --git a/relationships/candidates/MEMCACHED_EXPLICIT.yml b/relationships/candidates/MEMCACHED_EXPLICIT.yml
@@ -13,4 +13,6 @@ lookups:
     onMatch:
       onMultipleMatches: RELATE_ALL
     onMiss:
-      action: NO_OP
+      action: CREATE_UNINSTRUMENTED
+      uninstrumented:
+        type: MEMCACHED
diff --git a/relationships/candidates/REDIS_EXPLICIT.yml b/relationships/candidates/REDIS_EXPLICIT.yml
@@ -13,4 +13,6 @@ lookups:
     onMatch:
       onMultipleMatches: RELATE_ALL
     onMiss:
-      action: NO_OP
+      action: CREATE_UNINSTRUMENTED
+      uninstrumented:
+        type: REDIS
diff --git a/relationships/synthesis/EXT-SERVICE-to-MEMCACHED.yml b/relationships/synthesis/EXT-SERVICE-to-MEMCACHED.yml
@@ -152,7 +152,7 @@ relationships:
       - attribute: entity.type
         anyOf: [ "SERVICE" ]
       - attribute: newrelic.aws_metric_streams.arn
-        regex: "^arn:aws:elasticache:[^:]*:[^:]*:cluster/[^:]*"
+        regex: "^arn:aws:elasticache:[^:]*:[^:]*:cluster:[^:]+$"
     relationship:
       expires: P75M
       relationshipType: CALLS