Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New entity types for RAG #1886

Merged
merged 8 commits into from
Feb 3, 2025
Merged

New entity types for RAG #1886

merged 8 commits into from
Feb 3, 2025

Conversation

jstrinko
Copy link
Contributor

@jstrinko jstrinko commented Jan 29, 2025 •
edited
Loading

Relevant information

These definitions exist in NGEP and need to be added to the entity definitions.

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

@CLAassistant
Copy link

CLAassistant commented Jan 29, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

github-actions[bot]
github-actions bot previously approved these changes Jan 31, 2025
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Feb 3, 2025
View reviewed changes
lujop
lujop approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@lujop lujop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apoloa apoloa merged commit 0c9b128 into newrelic:main Feb 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lujop lujop lujop approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@entityBot entityBot entityBot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jstrinko @CLAassistant @lujop @entityBot @apoloa