Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attributes as per semantic convention and add more conditions #1925

Merged
merged 30 commits into from
Feb 20, 2025

Conversation

vinaykonatala
Copy link
Contributor

@vinaykonatala vinaykonatala commented Feb 19, 2025

Relevant information

Update attributes as per semantic convention and add more conditions

We are adding manually rpc.service and cloud.resource_id

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

github-actions[bot]
github-actions bot previously approved these changes Feb 19, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we go forward with the generic rule I've proposed in #1919 then this file can be deleted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have taken your PR as a guide, and I updated the relationship file.

@otaviocarvalho otaviocarvalho merged commit 9f8cf13 into newrelic:main Feb 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants