Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attributes as per semantic convention and add more conditions #1927

Merged
merged 30 commits into from
Feb 20, 2025
Merged

Update attributes as per semantic convention and add more conditions #1927

Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
91a69df
feat: Added kiness delivery stream
vinaykonatala Oct 25, 2024
c0a0e4f
Merge pull request #1 from vinaykonatala/NR-330033
vinaykonatala Oct 28, 2024
ca29b24
feat: Added relationship condition
vinaykonatala Oct 29, 2024
2423b3f
feat: Added relationship condition
vinaykonatala Oct 29, 2024
233e9a5
fix: Added apm kinesis relation file
vinaykonatala Oct 29, 2024
bce08df
fix:Removed apm relation file
vinaykonatala Oct 29, 2024
d2dd934
fix: Add new condition
vinaykonatala Nov 12, 2024
122b600
fix: Added quotes in array
vinaykonatala Nov 13, 2024
f3ab1ef
Merge branch 'main' into main
vinaykonatala Nov 13, 2024
9f6acf4
fix: Updated the tagkeys
vinaykonatala Nov 18, 2024
ac8ccb7
Merge branch 'main' of https://github.com/vinaykonatala/entity-defini…
vinaykonatala Nov 18, 2024
1002c5a
Merge branch 'main' into main
vinaykonatala Nov 18, 2024
0a78548
Merge branch 'main' into main
otaviocarvalho Nov 19, 2024
a128745
Merge branch 'newrelic:main' into main
vinaykonatala Nov 28, 2024
b6cc28d
Merge branch 'newrelic:main' into main
vinaykonatala Dec 10, 2024
592d791
Merge branch 'newrelic:main' into main
vinaykonatala Dec 12, 2024
ee47b4b
Merge branch 'newrelic:main' into main
vinaykonatala Dec 12, 2024
e2307e3
Merge branch 'newrelic:main' into main
vinaykonatala Dec 19, 2024
5d979bb
Merge branch 'newrelic:main' into main
vinaykonatala Jan 10, 2025
496939f
Merge branch 'newrelic:main' into main
vinaykonatala Jan 16, 2025
07515e1
Merge branch 'newrelic:main' into main
vinaykonatala Jan 22, 2025
c4589c5
Merge branch 'newrelic:main' into main
vinaykonatala Jan 29, 2025
bed8f1a
Merge branch 'newrelic:main' into main
vinaykonatala Jan 31, 2025
b6ef51f
Merge branch 'newrelic:main' into main
vinaykonatala Feb 7, 2025
ad85d46
Merge branch 'newrelic:main' into main
vinaykonatala Feb 10, 2025
8f8f215
Merge branch 'newrelic:main' into main
vinaykonatala Feb 19, 2025
d7b31bf
fix: Updated more attribute conditions
vinaykonatala Feb 19, 2025
994ae3f
fix: Updated the name and attributes
vinaykonatala Feb 20, 2025
854bb5f
Merge branch 'main' into kinesis
vinaykonatala Feb 20, 2025
b3454b9
Merge branch 'main' into kinesis
otaviocarvalho Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions relationships/synthesis/EXT-SERVICE-to-INFRA-KINESISSTREAM.yml
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we go forward with the generic rule I've proposed in #1919 then this file can be deleted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have taken your PR as a guide, and I updated the relationship file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the previous PR, going forward to unblock the team. Please sync on it and create a final PR.

Original file line number Diff line number Diff line change
@@ -1,15 +1,18 @@
relationships:
- name: extServiceCallsInfraKinesisStream
- name: extServiceCallsAwsKinesisStream_Explicit
version: "1"
origins:
- Distributed Tracing
- OpenTelemetry
conditions:
- attribute: eventType
anyOf: [ "Span" ]
- attribute: instrumentation.provider
anyOf: [ "opentelemetry" ]
- attribute: rpc.service
anyOf: [ "kinesis" ]
anyOf: [ "Log", "Span" ]
- attribute: newrelic.source
anyOf: [ "api.logs.otlp", "api.traces.otlp" ]
- attribute: entity.type
anyOf: [ "SERVICE" ]
- attribute: newrelic.aws_metric_streams.arn
regex: "^arn:aws:kinesis:([^:]*):([^:]*):stream/([^:]*)"
relationship:
expires: P75M
relationshipType: CALLS
Expand All @@ -21,4 +24,4 @@ relationships:
candidateCategory: AWSKINESISSTREAM
fields:
- field: cloudResourceId
attribute: cloud.resource_id
attribute: newrelic.aws_metric_streams.arn