Update attributes as per semantic convention and add more conditions for Kinesis delivery stream #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Adding candidate and relationship btw OTel and kiness delivery stream
entityBot
approved these changes
Feb 19, 2025
entityBot
approved these changes
Feb 19, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
alanwest
reviewed
Feb 19, 2025
There was a problem hiding this comment.
If we go forward with the generic rule I've proposed in #1919 then this file can be deleted.
There was a problem hiding this comment.
@alanwest I will go ahead w/ this one for now to unblock the team, please include the deletion of those in your PR too if you end up aligning on that.
Sounds good?
entityBot
approved these changes
Feb 20, 2025
entityBot
approved these changes
Feb 20, 2025
entityBot
approved these changes
Feb 20, 2025
entityBot
approved these changes
Feb 20, 2025
otaviocarvalho
approved these changes
Feb 20, 2025
entityBot
approved these changes
Feb 20, 2025
entityBot
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant information
Update attributes as per semantic convention and add more conditions
Added manually rpc.service and cloud.resource_id
Checklist
identifierwill be unique and valid.