Nr 372109 Add Connected System Device to Roku entity #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entityBot
approved these changes
Feb 24, 2025
entityBot
approved these changes
Feb 24, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
entityBot
approved these changes
Feb 24, 2025
entityBot
approved these changes
Feb 24, 2025
| @@ -0,0 +1,276 @@ | |||
| { | |||
| "name": "Connected Device System Entity Dashboard - WIP", | |||
There was a problem hiding this comment.
@avinash-newrelic any reason to keep it marked as WIP?
otaviocarvalho
approved these changes
Feb 24, 2025
entityBot
approved these changes
Feb 24, 2025
entityBot
approved these changes
Feb 24, 2025
avinash-newrelic
added a commit
to avinash-newrelic/entity-definitions
that referenced
this pull request
Feb 24, 2025
* NR-372109: Add Connected System to Roku Entity * fix: Indentation update * feat: Add Connected Device System entity * fix: Indendation error --------- Co-authored-by: Otávio Carvalho <[email protected]>
nr-cmorenoin
pushed a commit
that referenced
this pull request
Feb 25, 2025
* NR-372109: Add Connected System to Roku Entity * fix: Indentation update * feat: Add Connected Device System entity * fix: Indendation error * fix: Remove connected device system from roku entity * NR-372109 Add Connected System Device to Roku entity (#1940) * NR-372109: Add Connected System to Roku Entity * fix: Indentation update * feat: Add Connected Device System entity * fix: Indendation error --------- Co-authored-by: Otávio Carvalho <[email protected]> * fix: Remove connected device system from roku entity * fix: Indentation error * fix: Remove Connected Device System from Roku Entity * fix: Update ROku entity * fix: Typo error * fix: Remove connected devices * fix: Add rules * fix: Indentation --------- Co-authored-by: Otávio Carvalho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant information
Add ConnectedSystemDevice eventType along with RokuSystem for the Entity
Checklist
identifierwill be unique and valid.