Add Connected Devices System entity #1946
Merged
+23
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* NR-372109: Add Connected System to Roku Entity * fix: Indentation update * feat: Add Connected Device System entity * fix: Indendation error --------- Co-authored-by: Otávio Carvalho <[email protected]>
entityBot
suggested changes
Feb 24, 2025
There was a problem hiding this comment.
beep boop bop.
I have found some errors processing these changes:
* Error PARSING domainType: 'video-roku_system' on entitydefinitionemitter.models.BaseEntityDefinition - jackson.databind.exc.MismatchedInputException: Cannot deserialize value of type `entitydefinitionemitter.models.CustomEntitySynthesisRules` from Array value (token `JsonToken.START_ARRAY`)
at [Source: (StringReader); line: 7, column: 3] (through reference chain: entitydefinitionemitter.models.BaseEntityDefinition["synthesis"])
entityBot
suggested changes
Feb 24, 2025
There was a problem hiding this comment.
beep boop bop.
I have found some errors processing these changes:
* Error PARSING domainType: 'video-roku_system' on entitydefinitionemitter.models.BaseEntityDefinition - jackson.databind.exc.MismatchedInputException: Cannot deserialize value of type `entitydefinitionemitter.models.CustomEntitySynthesisRules` from Array value (token `JsonToken.START_ARRAY`)
at [Source: (StringReader); line: 7, column: 3] (through reference chain: entitydefinitionemitter.models.BaseEntityDefinition["synthesis"])
entityBot
approved these changes
Feb 25, 2025
entityBot
approved these changes
Feb 25, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
entityBot
approved these changes
Feb 25, 2025
entityBot
approved these changes
Feb 25, 2025
entityBot
approved these changes
Feb 25, 2025
entityBot
approved these changes
Feb 25, 2025
entityBot
approved these changes
Feb 25, 2025
entityBot
approved these changes
Feb 25, 2025
avinash-newrelic
changed the title
avinash-newrelic
changed the title
entityBot
approved these changes
Feb 25, 2025
entityBot
approved these changes
Feb 25, 2025
avinash-newrelic
changed the title
nr-cmorenoin
requested changes
Feb 25, 2025
| @@ -3,22 +3,13 @@ domain: VIDEO | |||
| type: ROKU_SYSTEM | |||
|
|
|||
| synthesis: | |||
| rules: | |||
There was a problem hiding this comment.
Are you removing the rules section intentionally?
entityBot
approved these changes
Feb 25, 2025
entityBot
approved these changes
Feb 25, 2025
nr-cmorenoin
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant information
Checklist
identifierwill be unique and valid.