Skip to content

chore: update team owners for ohai owned entities#2598

Merged
davidgonzalez-nr merged 2 commits into
newrelic:mainfrom
rajrohanyadav:entity-definition-governance-ohai
Jan 29, 2026
Merged

chore: update team owners for ohai owned entities#2598
davidgonzalez-nr merged 2 commits into
newrelic:mainfrom
rajrohanyadav:entity-definition-governance-ohai

Conversation

@rajrohanyadav

Copy link
Copy Markdown
Contributor

Relevant information

Checklist

  • I've read the guidelines and understand the acceptance criteria. - NA
  • The value of the attribute marked as identifier will be unique and valid. - NA
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above. - NA

entityBot
entityBot previously approved these changes Jan 23, 2026
@entityBot entityBot requested review from a team January 23, 2026 09:51
@entityBot entityBot requested a review from a team January 23, 2026 09:56
@rajrohanyadav rajrohanyadav marked this pull request as ready for review January 23, 2026 09:57

@sairaj18 sairaj18 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the change looks good to me. I see you have missed updating the code owner for couchbase integration. Can you update it?

@rajrohanyadav

Copy link
Copy Markdown
Contributor Author

Overall the change looks good to me. I see you have missed updating the code owner for couchbase integration. Can you update it?

Couchbase is a database and the ownership should reside with Database monitoring team.

@ujwalsah ujwalsah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the owners for OHAI related entities. I believe we need to add owner for infra-elasticsearchnode as well. Overall LGTM 🚀

@sairaj18 sairaj18 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidgonzalez-nr davidgonzalez-nr merged commit f133438 into newrelic:main Jan 29, 2026
4 checks passed
@rajrohanyadav rajrohanyadav deleted the entity-definition-governance-ohai branch January 30, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants