feat: Add new K8s pod <> pvc <> pv relationships in Stg#3003
Conversation
entityBot
left a comment
There was a problem hiding this comment.
beep boop bop.
I have found some errors processing these changes:
- No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach
#api-review-boardchannel in case of doubts
entityBot
left a comment
There was a problem hiding this comment.
beep boop bop.
I have found some errors processing these changes:
- No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach
#api-review-boardchannel in case of doubts
entityBot
left a comment
There was a problem hiding this comment.
We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.
entityBot
left a comment
There was a problem hiding this comment.
We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.
entityBot
left a comment
There was a problem hiding this comment.
We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.
| account: | ||
| lookup: true | ||
| domain: | ||
| value: INFRA | ||
| type: | ||
| value: KUBERNETES_PERSISTENTVOLUMECLAIM | ||
| identifier: | ||
| fragments: | ||
| - attribute: k8s.cluster.name | ||
| - value: ":" | ||
| - attribute: k8s.namespace.name | ||
| - value: ":" | ||
| - attribute: k8s.pvc.name | ||
| hashAlgorithm: FARM_HASH | ||
| target: | ||
| buildGuid: | ||
| account: | ||
| lookup: true |
There was a problem hiding this comment.
You cannot have lookup: true in both sides, one of the accounts has to be known
…-to-INFRA-KUBERNETES_PERSISTENTVOLUME.stg.yml Co-authored-by: Daniel Budziwojski <dbudziwojski@newrelic.com>
…ES_PERSISTENTVOLUMECLAIM.stg.yml Co-authored-by: Daniel Budziwojski <dbudziwojski@newrelic.com>
entityBot
left a comment
There was a problem hiding this comment.
We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.
entityBot
left a comment
There was a problem hiding this comment.
We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.
entityBot
left a comment
There was a problem hiding this comment.
We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.
…wson/entity-definitions into k8s-pod-pvc-relationships
entityBot
left a comment
There was a problem hiding this comment.
We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.
Relevant information
Adding new relationships for
PVC <> PV (replace Cluster <> PV)
POD <> PVC (otel rule is missing due to missing metrics)
Business justification doc: https://newrelic.atlassian.net/wiki/spaces/KOT/pages/5297407012/Business+Justification+for+K8s+Entities+relationships
Api Review Board (ARB)
ARB Jira ticket:
https://new-relic.atlassian.net/browse/NR-541144
Checklist
identifierwill be unique and valid.