Skip to content

feat: Add new K8s pod <> pvc <> pv relationships in Stg#3003

Merged
vlopeziglesias merged 13 commits into
newrelic:mainfrom
codylawson:k8s-pod-pvc-relationships
Jul 8, 2026
Merged

feat: Add new K8s pod <> pvc <> pv relationships in Stg#3003
vlopeziglesias merged 13 commits into
newrelic:mainfrom
codylawson:k8s-pod-pvc-relationships

Conversation

@codylawson

@codylawson codylawson commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Relevant information

Adding new relationships for

PVC <> PV (replace Cluster <> PV)
POD <> PVC (otel rule is missing due to missing metrics)

Business justification doc: https://newrelic.atlassian.net/wiki/spaces/KOT/pages/5297407012/Business+Justification+for+K8s+Entities+relationships

Api Review Board (ARB)
ARB Jira ticket:
https://new-relic.atlassian.net/browse/NR-541144

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach #api-review-board channel in case of doubts

@entityBot entityBot requested a review from a team July 1, 2026 16:48
@entityBot entityBot dismissed their stale review July 1, 2026 16:52

Let's validate those changes.

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach #api-review-board channel in case of doubts

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

entityBot
entityBot previously approved these changes Jul 6, 2026

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

Comment on lines +50 to +67
account:
lookup: true
domain:
value: INFRA
type:
value: KUBERNETES_PERSISTENTVOLUMECLAIM
identifier:
fragments:
- attribute: k8s.cluster.name
- value: ":"
- attribute: k8s.namespace.name
- value: ":"
- attribute: k8s.pvc.name
hashAlgorithm: FARM_HASH
target:
buildGuid:
account:
lookup: true

@vlopeziglesias vlopeziglesias Jul 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot have lookup: true in both sides, one of the accounts has to be known

…-to-INFRA-KUBERNETES_PERSISTENTVOLUME.stg.yml

Co-authored-by: Daniel Budziwojski <dbudziwojski@newrelic.com>
…ES_PERSISTENTVOLUMECLAIM.stg.yml

Co-authored-by: Daniel Budziwojski <dbudziwojski@newrelic.com>

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

@entityBot entityBot requested a review from a team July 8, 2026 14:44

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

entityBot
entityBot previously approved these changes Jul 8, 2026

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

@CLAassistant

CLAassistant commented Jul 8, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@vlopeziglesias vlopeziglesias merged commit 6b8abe9 into newrelic:main Jul 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants