Skip to content

k8s remove old relationships no longer needed#3006

Merged
vlopeziglesias merged 5 commits into
newrelic:mainfrom
codylawson:k8s-remove-old-relationships
Jul 10, 2026
Merged

k8s remove old relationships no longer needed#3006
vlopeziglesias merged 5 commits into
newrelic:mainfrom
codylawson:k8s-remove-old-relationships

Conversation

@codylawson

@codylawson codylawson commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Relevant information

Remove older relationships that is now derived from pod entity

Cluster <> Job
Cluster <> CronJob
Cluster <> PVC

Business justification doc: https://newrelic.atlassian.net/wiki/spaces/KOT/pages/5297407012/Business+Justification+for+K8s+Entities+relationships

Api Review Board (ARB)
ARB Jira ticket:
https://new-relic.atlassian.net/browse/NR-541144

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach #api-review-board channel in case of doubts

@entityBot entityBot requested a review from a team July 1, 2026 16:48
@entityBot entityBot dismissed their stale review July 1, 2026 16:52

Let's validate those changes.

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach #api-review-board channel in case of doubts

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

@codylawson codylawson marked this pull request as ready for review July 9, 2026 20:39

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

@vlopeziglesias vlopeziglesias merged commit 859cd94 into newrelic:main Jul 10, 2026
4 checks passed
@codylawson codylawson deleted the k8s-remove-old-relationships branch July 10, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants