fix(redis-otel): Use NO_OP instead of CREATE_UNINSTRUMENTED for clust…#3023
Merged
mborroni merged 1 commit intoJul 3, 2026
Merged
Conversation
…er candidate relationship
entityBot
approved these changes
Jul 3, 2026
entityBot
left a comment
Collaborator
There was a problem hiding this comment.
We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.
mborroni
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI failure introduced by the Redis OTel cluster candidate relationship file. Changes
onMissaction fromCREATE_UNINSTRUMENTEDtoNO_OPfor theREDISCLUSTERcandidate category.Problem
The
REDISCLUSTER.stg.ymlcandidate relationship usedCREATE_UNINSTRUMENTEDwhich requires a correspondinguninstrumented-rediscluster/definition.stg.ymlfile to exist. This file was missing, causing thevalidate_uninstrumented_definitions_existsCI check to fail for all PRs.Fix
Changed to
action: NO_OP— when an APM service references a Redis cluster that doesn't have an instrumented entity, do nothing instead of creating a placeholder. This matches the approach used by Kafka topics (PR #2994).Why NO_OP over CREATE_UNINSTRUMENTED
KAFKATOPIC.stg.yml)