Skip to content

fix(redis-otel): Use NO_OP instead of CREATE_UNINSTRUMENTED for clust…#3023

Merged
mborroni merged 1 commit into
newrelic:mainfrom
vagrawal-newrelic:fix/redis-otel-cluster-candidate-noop
Jul 3, 2026
Merged

fix(redis-otel): Use NO_OP instead of CREATE_UNINSTRUMENTED for clust…#3023
mborroni merged 1 commit into
newrelic:mainfrom
vagrawal-newrelic:fix/redis-otel-cluster-candidate-noop

Conversation

@vagrawal-newrelic

@vagrawal-newrelic vagrawal-newrelic commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes CI failure introduced by the Redis OTel cluster candidate relationship file. Changes onMiss action from CREATE_UNINSTRUMENTED to NO_OP for the REDISCLUSTER candidate category.

Problem

The REDISCLUSTER.stg.yml candidate relationship used CREATE_UNINSTRUMENTED which requires a corresponding uninstrumented-rediscluster/definition.stg.yml file to exist. This file was missing, causing the validate_uninstrumented_definitions_exists CI check to fail for all PRs.

Fix

Changed to action: NO_OP — when an APM service references a Redis cluster that doesn't have an instrumented entity, do nothing instead of creating a placeholder. This matches the approach used by Kafka topics (PR #2994).

Why NO_OP over CREATE_UNINSTRUMENTED

  • Avoids creating potentially confusing placeholder entities for customers
  • Simpler — no additional uninstrumented entity definition file needed
  • Consistent with the Kafka OTel pattern (KAFKATOPIC.stg.yml)
  • Relationships still work correctly when both entities are instrumented

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

@entityBot entityBot requested a review from a team July 3, 2026 10:37
@mborroni mborroni merged commit b3fd3c5 into newrelic:main Jul 3, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants