Skip to content

feat: Add golden and summary metrics for four GCP entity types#3027

Merged
vlopeziglesias merged 6 commits into
newrelic:mainfrom
sparsi17:feat/gcp-cloudtasks-entity
Jul 10, 2026
Merged

feat: Add golden and summary metrics for four GCP entity types#3027
vlopeziglesias merged 6 commits into
newrelic:mainfrom
sparsi17:feat/gcp-cloudtasks-entity

Conversation

@sparsi17

@sparsi17 sparsi17 commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

ARB ticket

https://new-relic.atlassian.net/browse/NR-567584

Relevant information

Batch PR adding golden_metrics.yml + summary_metrics.yml (and definition.yml updates where applicable) for four GCP entity types. Per-entity dashboards are intentionally omitted — dashboards are maintained in infra-summary templates going forward, so no dashboard.json file is included for any of these entities.

Entities included

Entity Resource type Golden metrics
GCPCLOUDTASKSQUEUE cloudtasks.googleapis.com/Queue (MRT cloud_tasks_queue) queue depth, task attempt count, task attempt delay
GCPAIPLATFORMPIPELINEJOB aiplatform.googleapis.com/PipelineJob (MRT aiplatform.googleapis.com/PipelineJob) pipeline run count, latency, success/failure counters
GCPFIREBASESTORAGEBUCKET firebasestorage.googleapis.com/Bucket (MRT firebasestorage_bucket) request count, bytes sent/received
GCPINTERCONNECTATTACHMENT compute.googleapis.com/InterconnectAttachment (MRT interconnect_attachment) network capacity, ingress/egress bytes and packets

Files changed per entity

Each entity folder adds:

  • golden_metrics.yml — key performance metrics
  • summary_metrics.yml — providerAccountName tag, gcp.projectId tag, plus references to golden metrics

Two entities also update definition.yml:

  • GCPCLOUDTASKSQUEUE — goldenTags: [gcp.projectId, gcp.region] (regional resource)
  • GCPFIREBASESTORAGEBUCKET — goldenTags: [gcp.projectId]

No dashboards

dashboard.json is not included for any of these entities. The infra-summary Nerdlet templates provide the interactive dashboards for these entity types, so per-entity dashboards in entity-definitions are redundant.

Metric sources

All metrics sourced from official GCP Cloud Monitoring docs:

  • https://cloud.google.com/monitoring/api/metrics_gcp_c#gcp-cloudtasks
  • https://cloud.google.com/monitoring/api/metrics_gcp_a_b#gcp-aiplatform
  • https://cloud.google.com/monitoring/api/metrics_gcp_d_h#gcp-firebasestorage
  • https://cloud.google.com/monitoring/api/metrics_gcp_i_o#gcp-interconnect

All referenced metrics are GA or BETA. NR attribute naming follows the standard gcp-polling-v2 convention (gcp.<service>.<metric_path>).

Companion PRs

Entity synthesis, UI definitions, and dashboards live in companion PRs:

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as `identifier` will be unique and valid.
  • I've confirmed that my entity type wasn't already defined.

@sparsi17
feat: Add GCPCLOUDTASKSQUEUE entity definition
bfd2e0b 
Adds golden_metrics.yml, summary_metrics.yml, and dashboard.json for
GCP Cloud Tasks Queue. Updates definition.yml with goldenTags
(gcp.projectId, gcp.region — queues are region-scoped).

Golden metrics: queue depth (max), task attempt count (sum), task
attempt delay (average, ms). Dashboard adds 3 additional widgets
faceted by response code, API method, and max delay.
entityBot
entityBot previously requested changes Jul 7, 2026
View reviewed changes

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach #api-review-board channel in case of doubts

@entityBot entityBot requested a review from a team July 7, 2026 14:05
@sparsi17
feat: Add GCPAIPLATFORMPIPELINEJOB Metric-based entity definition
641ded1 
- Add goldenTags (gcp.projectId, gcp.region)
- Add Metric-based queries to golden_metrics.yml alongside legacy Sample entries
- Update summary_metrics.yml formatting
- Add dashboard.json with 4 widgets (duration + task_completed_count)
@entityBot entityBot dismissed their stale review July 8, 2026 04:06

Let's validate those changes.

entityBot
entityBot previously requested changes Jul 8, 2026
View reviewed changes

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach #api-review-board channel in case of doubts

@sparsi17 sparsi17 mentioned this pull request Jul 8, 2026
Closed
3 tasks
@sparsi17 @claude
feat: Add GCPFIREBASESTORAGEBUCKET entity definition
74f9df6 
Adds golden metrics, summary metrics, dashboard and goldenTags for
Firebase Storage. Uses the Firebase-specific metric
gcp.firebasestorage.rules.evaluation_count (GA, DELTA) — the sole
firebasestorage.googleapis.com metric on gcs_bucket resource.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@entityBot entityBot dismissed their stale review July 8, 2026 05:13

Let's validate those changes.

entityBot
entityBot previously requested changes Jul 8, 2026
View reviewed changes

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach #api-review-board channel in case of doubts

@sparsi17 @claude
feat: Add GCPINTERCONNECTATTACHMENT entity definition
41a742c 
Adds golden_metrics.yml, summary_metrics.yml, and dashboard.json for
GCP Interconnect Attachment. All 11 GA metrics under
interconnect.googleapis.com/network/attachment/* are covered:
5 golden (Capacity, Ingress/Egress Bytes and Packets) plus dropped
packets and by-L3-protocol variants on the dashboard.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@entityBot entityBot dismissed their stale review July 8, 2026 05:17

Let's validate those changes.

entityBot
entityBot previously requested changes Jul 8, 2026
View reviewed changes

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach #api-review-board channel in case of doubts

@sparsi17 @claude
chore: Remove dashboard.json files from four GCP entity folders
01b605c 
Drops dashboard.json from:
- entity-types/infra-gcpaiplatformpipelinejob/
- entity-types/infra-gcpcloudtasksqueue/
- entity-types/infra-gcpfirebasestoragebucket/
- entity-types/infra-gcpinterconnectattachment/

Dashboard definitions are now maintained solely in infra-summary
templates; entity-definitions no longer carries per-entity dashboards.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@entityBot entityBot dismissed their stale review July 9, 2026 07:13

Let's validate those changes.

entityBot
entityBot requested changes Jul 9, 2026
View reviewed changes

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach #api-review-board channel in case of doubts

@sparsi17 sparsi17 changed the title feat: Add GCPCLOUDTASKSQUEUE entity definition feat: Add golden and summary metrics for four GCP entity types Jul 9, 2026
@sparsi17 @claude
fix(gcpaiplatformpipelinejob): rename golden metric query key `provid…
47f1f0e 
…er` -> `gcp`

The Metric-based query blocks in golden_metrics.yml were keyed under
`provider:` — this file used `gcp:` consistently before but the two new
entries drifted. Rename both to `gcp:` to match the sibling GCP entity
convention (single query key per data source).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@entityBot entityBot requested a review from a team July 9, 2026 12:38
@vlopeziglesias vlopeziglesias merged commit 675814b into newrelic:main Jul 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@entityBot entityBot entityBot approved these changes
@vlopeziglesias vlopeziglesias vlopeziglesias approved these changes
+1 more reviewer
@cnivyanthsai cnivyanthsai cnivyanthsai approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ARB:approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sparsi17 @entityBot @vlopeziglesias @cnivyanthsai