feat(azure): add AZUREVIRTUALNETWORKS candidate relationship for cros…#3039
feat(azure): add AZUREVIRTUALNETWORKS candidate relationship for cros…#3039nr-siranjeevi wants to merge 2 commits into
Conversation
entityBot
left a comment
There was a problem hiding this comment.
We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.
…s-subscription resolution (NR-582475, NR-584562) Adds a candidate relationship definition so the Entity Platform can resolve Azure VNet targets across subscriptions and across NR accounts natively, using the tag `azure.resourceId` that AZUREVIRTUALNETWORKS entities already carry. Files: - relationships/candidates/AZUREVIRTUALNETWORKS.yml Lookup on the `azure.resourceId` tag. `onMiss: CREATE_UNINSTRUMENTED` produces an `UNINSTRUMENTED-AZUREVIRTUALNETWORKS` placeholder when the target subscription is not yet integrated / scanned; the platform auto-swaps to the real `INFRA-AZUREVIRTUALNETWORKS` entity when it later appears. - entity-types/uninstrumented-azurevirtualnetworks/definition.yml Required by the CREATE_UNINSTRUMENTED action. Owned by CMP. Producer: azure-configuration-fetcher will emit CandidateRelationship messages against this category behind a per-NR-account feature flag that defaults to off. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
c163586 to
dcad3e7
Compare
entityBot
left a comment
There was a problem hiding this comment.
We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.
entityBot
left a comment
There was a problem hiding this comment.
We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.
|
Hi — could someone from the EP team take another look at this PR? Context:
Could you:
Thanks. |
Adds a candidate relationship definition so the Entity Platform can resolve
Azure VNet targets across subscriptions and across NR accounts natively,
using the tag
azure.resourceIdthat AZUREVIRTUALNETWORKS entities alreadycarry.
Related JIRA tickets:
Files:
relationships/candidates/AZUREVIRTUALNETWORKS.yml— Lookup on theazure.resourceIdtag.onMiss: CREATE_UNINSTRUMENTEDproduces anUNINSTRUMENTED-AZUREVIRTUALNETWORKSplaceholder when the target subscription is not yet integrated / scanned; the platform auto-swaps to the realINFRA-AZUREVIRTUALNETWORKSentity when it later appears.entity-types/uninstrumented-azurevirtualnetworks/definition.yml— Required by theCREATE_UNINSTRUMENTEDaction. Owned by CMP.Producer:
azure-configuration-fetcherwill emitCandidateRelationshipmessages against this category behind a per-NR-account feature flag that defaults to off. Skip-behavior side (which fixes the wrong-account registration bug from NR-584562) is already deployed to staging under azure-configuration-fetcher PR #42.Api Review Board (ARB)
Not required — the
ARB:not-requiredlabel has been applied to this PR. The change is additive (net-new candidate + net-new uninstrumented entity type owned by CMP), with no modifications to existing production entity types.Checklist
identifierwill be unique and valid.