Skip to content

feat(azure): add AZUREVIRTUALNETWORKS candidate relationship for cros…#3039

Open
nr-siranjeevi wants to merge 2 commits into
newrelic:mainfrom
nr-siranjeevi:feat/azure-vnet-candidate-cross-sub
Open

feat(azure): add AZUREVIRTUALNETWORKS candidate relationship for cros…#3039
nr-siranjeevi wants to merge 2 commits into
newrelic:mainfrom
nr-siranjeevi:feat/azure-vnet-candidate-cross-sub

Conversation

@nr-siranjeevi

@nr-siranjeevi nr-siranjeevi commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Adds a candidate relationship definition so the Entity Platform can resolve
Azure VNet targets across subscriptions and across NR accounts natively,
using the tag azure.resourceId that AZUREVIRTUALNETWORKS entities already
carry.

Related JIRA tickets:

  • NR-582475 — Cross Subscription must work across NR Accounts
  • NR-584562 — Block relationships to un-integrated subscriptions

Files:

  • relationships/candidates/AZUREVIRTUALNETWORKS.yml — Lookup on the azure.resourceId tag. onMiss: CREATE_UNINSTRUMENTED produces an UNINSTRUMENTED-AZUREVIRTUALNETWORKS placeholder when the target subscription is not yet integrated / scanned; the platform auto-swaps to the real INFRA-AZUREVIRTUALNETWORKS entity when it later appears.
  • entity-types/uninstrumented-azurevirtualnetworks/definition.yml — Required by the CREATE_UNINSTRUMENTED action. Owned by CMP.

Producer: azure-configuration-fetcher will emit CandidateRelationship messages against this category behind a per-NR-account feature flag that defaults to off. Skip-behavior side (which fixes the wrong-account registration bug from NR-584562) is already deployed to staging under azure-configuration-fetcher PR #42.

Api Review Board (ARB)

Not required — the ARB:not-required label has been applied to this PR. The change is additive (net-new candidate + net-new uninstrumented entity type owned by CMP), with no modifications to existing production entity types.

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined.
  • ARB approval is not required for this change (see label).

@CLAassistant

CLAassistant commented Jul 13, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

@entityBot entityBot requested a review from a team July 13, 2026 04:13
…s-subscription resolution (NR-582475, NR-584562)

Adds a candidate relationship definition so the Entity Platform can
resolve Azure VNet targets across subscriptions and across NR accounts
natively, using the tag `azure.resourceId` that AZUREVIRTUALNETWORKS
entities already carry.

Files:
- relationships/candidates/AZUREVIRTUALNETWORKS.yml
  Lookup on the `azure.resourceId` tag. `onMiss: CREATE_UNINSTRUMENTED`
  produces an `UNINSTRUMENTED-AZUREVIRTUALNETWORKS` placeholder when the
  target subscription is not yet integrated / scanned; the platform
  auto-swaps to the real `INFRA-AZUREVIRTUALNETWORKS` entity when it
  later appears.
- entity-types/uninstrumented-azurevirtualnetworks/definition.yml
  Required by the CREATE_UNINSTRUMENTED action. Owned by CMP.

Producer: azure-configuration-fetcher will emit CandidateRelationship
messages against this category behind a per-NR-account feature flag
that defaults to off.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@nr-siranjeevi nr-siranjeevi force-pushed the feat/azure-vnet-candidate-cross-sub branch from c163586 to dcad3e7 Compare July 13, 2026 05:40

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

aprasad-sketch
aprasad-sketch previously approved these changes Jul 13, 2026
@entityBot entityBot requested a review from a team July 13, 2026 09:15
@entityBot entityBot dismissed aprasad-sketch’s stale review July 14, 2026 15:57

Dismissing reviews

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

@entityBot entityBot requested review from a team and removed request for a team July 14, 2026 15:57
@nr-siranjeevi

nr-siranjeevi commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Hi — could someone from the EP team take another look at this PR? Context:

  • Adds a new AZUREVIRTUALNETWORKS candidate relationship + uninstrumented entity type (no changes to existing production types).
  • ARB is not required for this change — the ARB:not-required label is already applied.
  • Producer side is already deployed to staging under azure-configuration-fetcher PR Update golden metrics #42, feature flag defaulted off.

Could you:

  1. Re-add the EP:ready label (it was auto-removed when I pushed my last update).
  2. Approve the pending Actions workflow runs — FOSSA CLI Analysis and Validation are stuck at "Waiting for workflow to run" because this is a fork PR from an external-contributor account.

Thanks.

@entityBot entityBot requested a review from a team July 15, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants