Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nr 355273 ci optimization #197

Open
wants to merge 54 commits into
base: main
Choose a base branch
from
Open

Nr 355273 ci optimization #197

wants to merge 54 commits into from
+325 −94

Conversation

sanathramesh
Copy link
Contributor

@sanathramesh sanathramesh commented Jan 29, 2025 •
edited
Loading

This PR does the following :

  1. download and upload artifact action upgrade from v3 to v4
  2. increase forks for execution
  3. Add wait for connection before gathering facts in windows testing and suse build playbooks.
  4. Parallelise build suse + linux testing with windows testing
  5. increase async job wait time on windows(basically set ansible_win_async_startup_timeout to 3 minutes which by default is 5 seconds)
  6. Upgrade chocolatey version from 1.5.1 to 1.5.2
  7. Increase retries on aws ssm connection from 3 to 20 to avoid throttling issues.
  8. any_errors_fatal : This doesn't work with free strategy - only gives a warning, I have kept it there so that when there are failures, engineers can run that specific play without free strategy.
  9. Temporarily removed staging tests as fb 3.2.3 is currently in staging and it causes version mismatch. To prove that the flow works here is a run which was done e2e on fb 3.2.3 : https://github.com/newrelic/fluent-bit-package/actions/runs/13120106166

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2025 •
edited
Loading

Test Results

  1 files   28 suites   18m 32s ⏱️
  7 tests   5 ✅  2 💤 0 ❌
196 runs  140 ✅ 56 💤 0 ❌

Results for commit 72181a9.

♻️ This comment has been updated with latest results.

nr-rkallempudi
nr-rkallempudi approved these changes Feb 7, 2025
View reviewed changes
ansible/build-fb-suse/playbook.yml
roles:
- caos.ansible_roles.install_crowdstrike_falcon
gather_facts: no
any_errors_fatal: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any_errors_fatal : This doesn't work with free strategy - only gives a warning, I have kept it there so that when there are failures, engineers can run that specific play without free strategy.

Can you add the comment in the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nr-rkallempudi nr-rkallempudi nr-rkallempudi approved these changes

@maya-jha maya-jha Awaiting requested review from maya-jha

@hrai-nr hrai-nr Awaiting requested review from hrai-nr

@ahegdeNR ahegdeNR Awaiting requested review from ahegdeNR

@rohit-bandlamudi-nr rohit-bandlamudi-nr Awaiting requested review from rohit-bandlamudi-nr

@gunnalahema gunnalahema Awaiting requested review from gunnalahema

@voorepreethi voorepreethi Awaiting requested review from voorepreethi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanathramesh @nr-rkallempudi @gunnalahema