Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slog 2.0 #997

Merged
merged 7 commits into from
Feb 19, 2025
Merged

Slog 2.0 #997

merged 7 commits into from
Feb 19, 2025

Conversation

iamemilio
Copy link
Contributor

@iamemilio iamemilio commented Jan 31, 2025

A new approach to integrating New Relic with SLOG that is more lightweight, out of the way, and collects richer data. These changes have been constructed to be completely backwards compatible with v1 of nrslog. Changes include:

  • A way to wrap slog.Handler objects with errors to allow users to handle invalid use cases
  • A complete rework of log enrichment so that new relic linking metadata does not invalidate json, bson, or yaml scanners. This new approach will instead inject the linking metadata as a key value pair.
  • Complete support for With(), WithGroup() and attributes for automatic instrumentation.
  • A number of performance operations
  • Robust testing at close to 90% coverage

@iamemilio iamemilio marked this pull request as ready for review February 11, 2025 20:55
@nr-swilloughby nr-swilloughby merged commit 18613dc into newrelic:develop Feb 19, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants