Skip to content

Conversation

@tspearconquest
Copy link

Is this a new chart

No

What this PR does / why we need it:

Restores image registry override behavior from chart version 0.2.7 and earlier, while keeping the newer tag selection behavior, removes a line break after the image field in both containers of the ebpf agent and the otel collector, and makes the ebpf agent init container image selection consistent with the container

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [mychartname])

Release Notes to Publish (nr-k8s-otel-collector)

If this PR contains changes in nr-k8s-otel-collector, please complete the following section. All other charts should ignore this section.

🚀 What's Changed

  • Tell the world about the latest changes in the chart.

…rt 0.2.7 and earlier while keeping tag selection behavior from chart 0.2.8 and later, remove line break after image field, and make init container image consistent with ebpf agent container image

Signed-off-by: Thomas Spear <[email protected]>
Signed-off-by: Thomas Spear <[email protected]>
@tspearconquest tspearconquest changed the title [nr-ebpf-agent] Bugfix: Restore image path override behavior from chart 0.2.7 and earlier while keeping tag selection behavior from chart 0.2.8 and later, remove line break after image field, and make init container image consistent with ebpf agent container image [nr-ebpf-agent] Sync init container image path with container image path so that the init container image location can be set via values.yaml Nov 7, 2025
@tspearconquest
Copy link
Author

Hi @burhan-nr @kkhandelwal-nr please kindly review and approve. I have incorporated the latest updates on the chart to this PR.

@burhan-nr
Copy link
Contributor

Hi @burhan-nr @kkhandelwal-nr please kindly review and approve. I have incorporated the latest updates on the chart to this PR.

Hi @tspearconquest. We have provided these changes to the team for testing. Once everything looks good, we will merge it.

@stefansedich
Copy link

Hi @burhan-nr @kkhandelwal-nr please kindly review and approve. I have incorporated the latest updates on the chart to this PR.

Hi @tspearconquest. We have provided these changes to the team for testing. Once everything looks good, we will merge it.

@burhan-nr do we know when this might be merged? I am seeking this functionality as we run all of our external images from a private ECR repo.

@kkhandelwal-nr
Copy link
Contributor

@stefansedich We are planning to add this change in our next helm chart release v1.0.1. Change pushed here.
You can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants