[nr-k8s-otel-collector] Adding registry and imagePullSecrets configuration#2000
Merged
dbudziwojskiNR merged 5 commits intonewrelic:masterfrom Dec 2, 2025
Merged
Conversation
…ets configuration
Contributor
|
Thanks @tviaud for your great proposal! We will allocate some time from the team to make a first review during the next sprint. |
…support # Conflicts: # charts/nr-k8s-otel-collector/Chart.yaml # charts/nr-k8s-otel-collector/examples/k8s/rendered/clusterrole.yaml # charts/nr-k8s-otel-collector/examples/k8s/rendered/clusterrolebinding.yaml # charts/nr-k8s-otel-collector/examples/k8s/rendered/daemonset-configmap.yaml # charts/nr-k8s-otel-collector/examples/k8s/rendered/daemonset.yaml # charts/nr-k8s-otel-collector/examples/k8s/rendered/deployment-configmap.yaml # charts/nr-k8s-otel-collector/examples/k8s/rendered/deployment.yaml # charts/nr-k8s-otel-collector/examples/k8s/rendered/secret.yaml # charts/nr-k8s-otel-collector/examples/k8s/rendered/service.yaml # charts/nr-k8s-otel-collector/examples/k8s/rendered/serviceaccount.yaml
dbudziwojskiNR
approved these changes
Dec 2, 2025
TmNguyen12
reviewed
Dec 2, 2025
TmNguyen12
approved these changes
Dec 2, 2025
dpacheconr
pushed a commit
to dpacheconr/helm-charts
that referenced
this pull request
Dec 15, 2025
…ation (newrelic#2000) <!-- Thank you for contributing to New Relic's Helm charts. Before you submit this PR we'd like to make sure you are aware of our technical requirements: * https://github.com/newrelic-experimental/helm-charts/blob/master/CONTRIBUTING.md#technical-requirements For a quick overview across what we will look at reviewing your PR, please read our review guidelines: * https://github.com/newrelic-experimental/helm-charts/blob/master/REVIEW_GUIDELINES.md Following our best practices right from the start will accelerate the review process and help get your PR merged quicker. When updates to your PR are requested, please add new commits and do not squash the history. This will make it easier to identify new changes. The PR will be squashed anyways when it is merged. Thanks. For fast feedback, please @-mention maintainers that are listed in the Chart.yaml file. Please make sure you test your changes before you push them. Once pushed, a Github Action will run across your changes and do some initial checks and linting. These checks run very quickly. Please check the results. We would like these checks to pass before we even continue reviewing your changes. --> #### Is this a new chart No #### What this PR does / why we need it: Adding image configuration based on the `nri-bundle` chart to use the same standard (https://github.com/newrelic/helm-charts/blob/master/charts/nri-bundle/values.yaml#L100). With the recent addition of the `kubectl` image we needed to be able to configure the registry of images as mandated within our organisation. This is making use of the NewRelic Common library to achieve this. This will be a breaking change for people configuring their image repository using the `image` section of the current chart (replaced by `images` section in this PR). Added imagePullSecrets support for authenticated registries as well. #### Which issue this PR fixes *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)* - fixes # #### Special notes for your reviewer: #### Checklist [Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.] - [x] Chart Version bumped - [x] Variables are documented in the README.md - [x] Title of the PR starts with chart name (e.g. `[mychartname]`) # Release Notes to Publish (nr-k8s-otel-collector) If this PR contains changes in `nr-k8s-otel-collector`, please complete the following section. All other charts should ignore this section. <!--BEGIN-RELEASE-NOTES--> ## 🚨 Upcoming Breaking Changes * Removed `image` configuration in favor of `images` section. The following config is deprecated and will be removed in a future release. * 'image.repository' has been replaced with 'images.collector.repository'. * 'image.tag' has been replaced with 'images.collector.tag'. * 'image.pullPolicy' has been replaced with 'images.collector.pullPolicy'. ## 🚀 What's Changed * Added images configuration with registry support for both `collector` and `kubectl` images via `images` configuration. * Added imagePullSecrets support for authenticated registries. <!--END-RELEASE-NOTES--> --------- Co-authored-by: Daniel Budziwojski <dbudziwojski@newrelic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this a new chart
No
What this PR does / why we need it:
Adding image configuration based on the
nri-bundlechart to use the same standard (https://github.com/newrelic/helm-charts/blob/master/charts/nri-bundle/values.yaml#L100). With the recent addition of thekubectlimage we needed to be able to configure the registry of images as mandated within our organisation.This is making use of the NewRelic Common library to achieve this.
This will be a breaking change for people configuring their image repository using the
imagesection of the current chart (replaced byimagessection in this PR).Added imagePullSecrets support for authenticated registries as well.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname])Release Notes to Publish (nr-k8s-otel-collector)
If this PR contains changes in
nr-k8s-otel-collector, please complete the following section. All other charts should ignore this section.🚨 Upcoming Breaking Changes
imageconfiguration in favor ofimagessection. The following config is deprecated and will be removed in a future release.🚀 What's Changed
collectorandkubectlimages viaimagesconfiguration.