feat: add global.images registry, pullSecrets, and pullPolicy support to nri-bundle charts #2005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpacheconr
changed the title
dpacheconr
force-pushed
the
support/newrelic-logging-final
branch
from
8fbed24 to
2228ff7
Compare
dpacheconr
changed the title
dpacheconr
force-pushed
the
support/newrelic-logging-final
branch
from
4d3ce3b to
fb84891
Compare
…onset Update imagePullSecrets handling to cascade from global.images.pullSecrets: - Updated daemonset.yaml to include global.images.pullSecrets rendering - Both global and chart-level pullSecrets are concatenated together Configuration hierarchy: 1. global.images.pullSecrets (applied first) 2. image.pullSecrets (applied second - chart level) Both sources are concatenated to support flexible secret management.
Add support for cascading pullPolicy from global.images.pullPolicy setting:
- Added pullPolicy helpers to _helpers.tpl
- Updated main image and init container helpers to support global pullPolicy
Configuration hierarchy for pullPolicy:
1. global.images.pullPolicy (highest priority)
2. Chart-level image.pullPolicy
3. Default: IfNotPresent
Users can now configure pull policy globally:
global:
images:
pullPolicy: Always
dpacheconr
force-pushed
the
support/newrelic-logging-final
branch
from
fb84891 to
22c6dab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for cascading registry, pullSecrets, and pullPolicy from global settings across multiple nri-bundle charts.
Phase 1: Global.Images.Registry Support ✅
fluentBit.persistenceInitContainerImage) now respectsglobal.images.registrynewrelic-logging.persistenceInitContainerImagein _helpers.tplPhase 2: Global.Images.PullSecrets Support ✅
Phase 3: Global.Images.PullPolicy Support ✅ (NEW)
Changes by Chart
newrelic-logging (Phase 1 + Phase 2 + Phase 3)
Files Changed:
charts/newrelic-logging/values.yaml- AddedpersistenceInitContainerImageconfigurationcharts/newrelic-logging/templates/_helpers.tpl- Added registry and pullPolicy helperscharts/newrelic-logging/templates/daemonset.yaml- Updated init container and imagePullSecrets/pullPolicy renderingConfiguration Hierarchy:
global.images.registry→fluentBit.persistenceInitContainerImage.repositoryglobal.images.pullSecrets→image.pullSecretsglobal.images.pullPolicy→fluentBit.image.pullPolicyTest Plan
Phase 1 (newrelic-logging Registry):
my.private.registry.com/busybox:1.36busybox:1.36Phase 2 (PullSecrets):
Phase 3 (PullPolicy):
Impact
Once merged, users can now configure image pull behavior globally:
```yaml
global:
images:
registry: "my.private.registry.com"
pullSecrets:
- name: my-registry-credentials
pullPolicy: Always
```
This eliminates the need to configure these settings individually for each nri-bundle sub-chart.