[nr-k8s-otel-collector, nri-bundle] Resource defaults #2012
Merged
Philip-R-Beckwith merged 15 commits intomasterfrom Nov 19, 2025
Merged
[nr-k8s-otel-collector, nri-bundle] Resource defaults #2012Philip-R-Beckwith merged 15 commits intomasterfrom
Philip-R-Beckwith merged 15 commits intomasterfrom
Conversation
kondracek-nr
previously approved these changes
Nov 18, 2025
dbudziwojskiNR
approved these changes
Nov 19, 2025
dpacheconr
pushed a commit
to dpacheconr/helm-charts
that referenced
this pull request
Dec 15, 2025
#### Is this a new chart It is NOT a new chart. #### What this PR does / why we need it: Adds defaults for resource requirements to prevent otel from logging WARN messages when installing these charts. #### Which issue this PR fixes *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)* N/A #### Special notes for your reviewer: This PR is aimed at ensuring that customers can always set resource values. It adds a passthrough for the init container to inherit the same limits as the collector that is booted after it runs. I've also added empty resource config blocks for the kube-state-metrics sub-chart as in-line documentation to let user's know that this is one of the config options available to be passed to the kube state metrics chart. Not only is it just good practise to ensure our customers have easy access to these settings, but It's especially important for GKE Autopilot users who get warnings and default limits set on them if they are not set manually. Which is what drove this effort, so I've also added a callout in the readme for that. #####No Resource values set: <img width="1492" height="233" alt="Screenshot 2025-11-18 at 11 50 01 AM" src="https://github.com/user-attachments/assets/c61a6969-e121-46eb-a57b-bf2fd530d7f8" /> #####With Resource values set: <img width="710" height="125" alt="Screenshot 2025-11-18 at 11 48 38 AM" src="https://github.com/user-attachments/assets/12f18a9b-cb8b-4465-ad01-1210e32d4b41" /> #### Checklist [Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.] - [x] Chart Version bumped - [x] Variables are documented in the README.md - [x] Title of the PR starts with chart name (e.g. `[mychartname]`) # Release Notes to Publish (nr-k8s-otel-collector) If this PR contains changes in `nr-k8s-otel-collector`, please complete the following section. All other charts should ignore this section. <!--BEGIN-RELEASE-NOTES--> ## 🚀 What's Changed * Adding empty resource blocks for the Kube-state-metrics subchart in the Values.yaml to appease providers that do not allow empty resource blocks. * Adds the user set resource values for the daemonset init container. <!--END-RELEASE-NOTES-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this a new chart
It is NOT a new chart.
What this PR does / why we need it:
Adds defaults for resource requirements to prevent otel from logging WARN messages when installing these charts.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)N/A
Special notes for your reviewer:
This PR is aimed at ensuring that customers can always set resource values. It adds a passthrough for the init container to inherit the same limits as the collector that is booted after it runs. I've also added empty resource config blocks for the kube-state-metrics sub-chart as in-line documentation to let user's know that this is one of the config options available to be passed to the kube state metrics chart.
Not only is it just good practise to ensure our customers have easy access to these settings, but It's especially important for GKE Autopilot users who get warnings and default limits set on them if they are not set manually. Which is what drove this effort, so I've also added a callout in the readme for that.
#####No Resource values set:

#####With Resource values set:

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname])Release Notes to Publish (nr-k8s-otel-collector)
If this PR contains changes in
nr-k8s-otel-collector, please complete the following section. All other charts should ignore this section.🚀 What's Changed