nr-k8s-otel-collector: Add Comprehensive Global Value Inheritance Test Coverage

[dpacheconr]

Overview

This PR adds comprehensive test coverage with EXPLICIT validation of global value inheritance for all applicable values from the common-library, plus implementation of global.customAttributes support. Each applicable global value has dedicated test cases that directly validate propagation and override precedence. The chart now supports custom attributes injection into OpenTelemetry resource processors.

Testing Philosophy

This chart validates ALL applicable global values through comprehensive helm-unittest tests. While common-library helpers handle the implementation, we test each global value with dedicated test cases showing both inheritance (global → chart) and precedence (local > global > default). This is infrastructure-as-code best practice providing confidence that configuration changes work as expected.

Changes

Added global.customAttributes Support

• Implemented custom attributes injection into resource/newrelic processor
• Custom attributes propagate as OpenTelemetry resource attributes in both ConfigMaps
• Supports both global.customAttributes and local customAttributes with proper override precedence
• Enables standard common-library global value patterns while maintaining OTel-native configuration

Added Test Suite

• Added 82 new test cases in tests/global_inheritance_test.yaml (79 original + 3 fedramp)
• Validates all 21 applicable global values with proper precedence
• Tests include global value propagation, local override, and default state handling
• Validates both Deployment AND DaemonSet templates (dual workload architecture)
• Includes ConfigMap propagation for chart-specific values (lowDataMode, nrStaging, verboseLog)
• Includes Secret references for sensitive data (licenseKey, customSecretName)
• Bumped chart version from 0.9.7 to 0.9.8

Test Results

Charts:      1 passed (1 total)
Test Suites: 20 passed (20 total)
Tests:       192 passed (192 total)
Pass Rate:   100%

Test coverage includes:

• 82 new tests for global value inheritance validation (79 original + 3 fedramp)
• 110 existing tests continue to pass
• All applicable global values validated with proper precedence

Global Values Coverage

All 27 global values from the common-library assessed:

Legend:

• Applicable: Whether this global value applies to this chart type
• Tested: Test coverage approach (all applicable values must be tested)
  • Yes - Chart includes explicit helm-unittest test coverage
  • No - Value not applicable to this chart type
• Notes: Additional context about implementation or test coverage

All applicable global values have explicit test coverage with dedicated test cases and assertions.

Global Value	Applicable	Tested	Notes
cluster	Yes	Yes	ConfigMap validation - 4 tests with inheritance + precedence
licenseKey	Yes	Yes	Secret reference validation - 4 tests with inheritance + precedence
customSecretName	Yes	Yes	Alternative auth path - 4 tests with inheritance + precedence
customSecretLicenseKey	Yes	Yes	Used with customSecretName for secret key override
insightsKey	No	No	Deprecated, excluded from all charts
provider	No	No	Not used by this chart (no provider-specific logic)
labels	Yes	Yes	Resource labels - 4 tests (propagation + merge behavior)
podLabels	Yes	Yes	Pod template labels - 3 tests (propagation + merge)
images.registry	Yes	Yes	Collector + kubectl images - 5 tests with precedence
images.pullSecrets	Yes	Yes	Image pull secrets - 3 tests (merge behavior)
images.pullPolicy	Yes	Yes	Existing tests validate pullPolicy configuration
serviceAccount.create	Yes	Yes	7 tests in serviceaccount_test.yaml - creation control
serviceAccount.name	Yes	Yes	Custom SA name - 3 tests with inheritance + precedence
serviceAccount.annotations	Yes	Yes	IRSA/Workload Identity - 2 tests (propagation + merge)
hostNetwork	No	No	Not configurable (chart doesn't require host network)
dnsConfig	Yes	Yes	DNS configuration - 3 tests with inheritance + precedence
proxy	Yes	Yes	HTTP/HTTPS proxy - 4 tests with inheritance + precedence
priorityClassName	Yes	Yes	Pod priority - 3 tests with inheritance + precedence
nodeSelector	Yes	Yes	Node selection - 5 tests (chart/deployment/daemonset levels)
tolerations	Yes	Yes	Node taints - 5 tests (chart/deployment/daemonset levels)
affinity	Yes	Yes	Scheduling affinity - 5 tests (chart/deployment/daemonset levels)
podSecurityContext	Yes	Yes	Pod-level security - 5 tests (chart/deployment/daemonset)
containerSecurityContext	Yes	Yes	Container security - 5 tests (chart/deployment/daemonset)
privileged	No	No	Deployment/DaemonSet don't require privileged mode (secure by design)
customAttributes	Yes	Yes	OTel resource attributes - 5 tests (propagation + merge + override)
lowDataMode	Yes	Yes	Reduced telemetry - 3 tests with inheritance + precedence
fargate	No	No	Not specific to Fargate (works on any node type)
nrStaging	Yes	Yes	Staging endpoint - 2 tests (deployment + daemonset)
verboseLog	Yes	Yes	Debug logging - 2 tests (deployment + daemonset ConfigMap)
fedramp.enabled	Yes	Yes	FedRAMP endpoint - 3 tests (propagation + precedence)
TOTAL	21/27	21/27	All applicable values have explicit tests

Chart-Specific Behavior

Cluster Name Propagation

The cluster name is set in the ConfigMap (via resource attributes) rather than as an environment variable. This is validated through ConfigMap pattern matching in the test suite.

License Key Handling

The chart always uses a Secret reference (not plain values) for the license key. This is the secure pattern and is validated through Secret reference assertions.

Dual Workload Architecture

The chart deploys BOTH a Deployment (cluster-wide metrics) AND a DaemonSet (per-node metrics). All tests validate both templates to ensure consistent behavior across both workload types.

Custom Attributes as OTel Resource Attributes

Custom attributes from global.customAttributes and local customAttributes are injected into the OpenTelemetry collector's resource/newrelic processor as resource attributes. This allows standard global value patterns while maintaining OTel-native configuration.

Files Modified

New Files

• charts/nr-k8s-otel-collector/tests/global_inheritance_test.yaml - Added 79 test cases

Modified Files

• charts/nr-k8s-otel-collector/Chart.yaml - Bumped version 0.9.7 → 0.9.8
• charts/nr-k8s-otel-collector/templates/deployment-configmap.yaml - Added custom attributes support
• charts/nr-k8s-otel-collector/templates/daemonset-configmap.yaml - Added custom attributes support
• charts/nr-k8s-otel-collector/templates/_endpoint.tpl - Added fedramp.enabled support for gov endpoint

No Breaking Changes

• Custom attributes feature is additive (backward compatible)
• All 110 existing tests still passing
• Template changes: additive only (custom attributes injection in ConfigMaps)
• No value schema changes (uses existing common-library pattern)
• No behavioral changes to existing configurations
• Backward compatible with all existing configurations
• All global values already properly implemented via common-library helpers

Build Status

Tests:  192/192 passing (100%)
Lint:   Passing
Build:  Successful

Changelog Entry

## [0.9.8] - 2025-12-03

### Added
- Add global.customAttributes support with injection into resource/newrelic processor
- Add global.fedramp.enabled support for FedRAMP gov endpoint (gov-otlp.nr-data.net)
- Add comprehensive global value inheritance test coverage for 21 applicable global values
- Add 82 new test cases validating global value propagation and override precedence

### Changed
- Enhanced ConfigMaps to support custom attributes as OpenTelemetry resource attributes

[mangulonr]

Added to backlog