Open
Conversation
- Changed service.yaml to use existing ping-runtime.name template - This allows nameOverride to work correctly for the service - Bumped chart version from 1.0.29 to 1.0.30
- Updated ping-runtime dependency version to 1.0.30 - Bumped chart version from 3.0.41 to 3.0.42 Related to issue newrelic#2028
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this a new chart
No
What this PR does / why we need it:
Fixes a bug in the ping-runtime subchart where
service.yamlreferences a non-existent template functionping-runtime.hostname. This prevented the service name from being configurable vianameOverride, which blocked deploying multiple isolated ping-runtime instances in the same namespace (as recommended in the New Relic scaling documentation).Problem: When scaling out ping-runtime with different
nameOverridevalues, multiple Deployments were created correctly but multiple Services could not be created because the service name was not configurable.Solution: Updated
service.yamlto use the existingping-runtime.nametemplate function, enablingnameOverrideto work correctly for both Deployments and Services.Testing: Validated locally with
ct lintand deployed to a test cluster with multiple ping-runtime instances to confirm each service now has a unique, configurable name.Which issue this PR fixes
Special notes for your reviewer:
This PR includes changes to both the
ping-runtimesubchart and its parentsynthetics-job-managerchart:ping-runtime/templates/service.yaml: Fixed template function reference (hostname → name)ping-runtime/Chart.yaml: Version bump 1.0.29 → 1.0.30synthetics-job-manager/Chart.yaml: Updated dependency version and chart version 3.0.41 → 3.0.42All local validation tests passed including
ct lintand deployment testing with multiple instances.@Philip-R-Beckwith @sshah-nr @vkasanneni-nr @marcusperezNR @mderemer-nr @kaschaefer-nr @sadafarshad @lromer22 @kondracek-nr @sidnaiknewrelic
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname])Release Notes to Publish (nr-k8s-otel-collector)
If this PR contains changes in
nr-k8s-otel-collector, please complete the following section. All other charts should ignore this section.🚀 What's Changed