[nr-ebpf-agent]: cos and bottle rocket support#2035
Conversation
| echo "/host/etc/os-release not found" | ||
| echo "Proceeding without kernel header install." | ||
| fi | ||
| image: {{ .Values.ebpfAgent.image.repository }}:agent-base-image-latest |
There was a problem hiding this comment.
Should the image tag here not be configurable too?
stefansedich
left a comment
There was a problem hiding this comment.
We would need the image tag for the init container configurable too for this to work for us.
<meta charset="utf-8"><b style="font-weight:normal;" id="docs-internal-guid-41b7f31b-7fff-e5e4-8bcd-5846874602bb"><h3 dir="ltr" style="line-height:1.38;margin-top:16pt;margin-bottom:4pt;"><span style="font-size:13.999999999999998pt;font-family:Arial,sans-serif;color:#434343;background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre;white-space:pre-wrap;">k8s : </span></h3><br /><div dir="ltr" style="margin-left:0pt;" align="left"> Current env name | Renamed -- | -- tcpStatsReporting | networkMetricsReporting dropDataNewRelic | allDataFilters.dropNewRelicBundle dropDataForNamespaces | allDataFilters.dropNamespaces dropDataServiceNameRegex | allDataFilters.dropDataServiceNameRegex allowServiceNameRegex | allDataFilters.keepServiceNameRegex tcpStatsReporting | networkMetricsReporting </div></b> <meta charset="utf-8"><b style="font-weight:normal;" id="docs-internal-guid-9267a4b7-7fff-1975-0a68-ea2021ac0361"><h3 dir="ltr" style="line-height:1.38;margin-top:16pt;margin-bottom:4pt;"><span style="font-size:13.999999999999998pt;font-family:Arial,sans-serif;color:#434343;background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre;white-space:pre-wrap;">env:</span></h3><br /><div dir="ltr" style="margin-left:0pt;" align="left"> Current env name | Renamed -- | -- DROP_DATA_NEW_RELIC | DROP_ALL_DATA_FOR_NEW_RELIC DROP_APM_ENABLED_PODS | DROP_ALL_DATA_FOR_APM_AGENT_ENABLED_ENTITY DROP_DATA_FOR_NAMESPACES | DROP_ALL_DATA_FOR_NAMESPACES DROP_SERVICE_NAME_REGEX | DROP_ALL_DATA_FOR_SERVICE_NAME_REGEX ALLOW_SERVICE_NAME_REGEX | DROP_ALL_DATA_FOR_ENTITY_NAME_REGEX DROP_DATA_FOR_ENTITY | DROP_ALL_DATA_FOR_ENTITY_NAME_REGEX TCP_STATS_REPORTING | NETWORK_METRICS_REPORTING </div><br /><br /></b>
This reverts commit 024228b.
|
@stefansedich We'll need to introduce a new param in the |
@kkhandelwal-nr we utilize immutable tags in our private ECR repo where we copy images to, a mutable tag would not work for us and is not best practice either, a new version of an image should be a new tag. |
|
@kkhandelwal-nr any guidance on this one? would it be possible for the init container to use an image that does not have a mutable tag? |
|
@stefansedich The base image for init container is updated only when we need to upgrade package version that resides in the image. Other than that, there is no update in functionality. Hence we keep this a mutable tag. |
I assume we could then just use the main versioned image for the init container? if so that would work for us. |
|
Yes. Since we push updates for base image to same tag, you can pull that image, retag it for your private ECR repo and use your tag in the |
So I am unable to use the If these are seperate images it would make more sense if the image lived at say Mashing it into the single repo like this and providing only a |
Yes, these are separate images.
As mentioned earlier, we hardly make any updates in the base image. Hence we kept a mutable tag and used the existing repo. In future, we can surely move this to a separate repo if the changes are too frequent. |
Is this a new chart
No
What this PR does / why we need it:
apmDataFilters: Filter APM data by pod labels, entity names, or APM agent presencenetworkMetricsDataFilter: Filter network metrics by pod labels or entity namesallDataFilters: Global filters affecting all data typestcpStatsReporting→ networkMetricsReportingdropDataNewRelic→ allDataFilters.dropNewRelicBundledropDataForNamespaces→ allDataFilters.dropNamespacesdropDataServiceNameRegex→ allDataFilters.dropServiceNameRegexallowServiceNameRegex→ allDataFilters.keepServiceNameRegexWhich issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname])