Skip to content

[newrelic-logging] Fix invalid daemonset yaml when specific values are set#2058

Open
aisling-mls wants to merge 3 commits intonewrelic:masterfrom
aisling-mls:fix-daemonset-yaml
Open

[newrelic-logging] Fix invalid daemonset yaml when specific values are set#2058
aisling-mls wants to merge 3 commits intonewrelic:masterfrom
aisling-mls:fix-daemonset-yaml

Conversation

@aisling-mls
Copy link

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Moves existing yaml lines to correct location for valid yaml generation. Currently when .Values.exposedPorts are set the lua-scripts volume mount entry is placed under <...>.ports when it should be under <...>.volumeMounts.
Additionally, this fixes a related bug where if .Values.resources is not set then the volume mount is not created.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])

Release Notes to Publish (nr-k8s-otel-collector)

If this PR contains changes in nr-k8s-otel-collector, please complete the following section. All other charts should ignore this section.

🚀 What's Changed

  • Fix issue with invalid yaml for daemonset when specific values are set.

@aisling-mls aisling-mls requested a review from a team as a code owner January 6, 2026 21:04
@CLAassistant
Copy link

CLAassistant commented Jan 6, 2026

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[newrelic-logging] Invalid yaml generated when .Values.exposedPorts, .Values.resources, and .Values.fluentBit.fluentBitMetrics are all set

2 participants

Comments