Open
Conversation
gmanandhar-nr
commented
Jan 20, 2026
| # mute_process_exe_error: true | ||
| # mute_process_io_error: true | ||
| # mute_process_user_error: true | ||
| processes: |
Member
Author
There was a problem hiding this comment.
@dbudziwojskiNR Noticed one of the checks: "Check Generated file" is failing. Do we make changes to "rendered" folder as well manually, or are they auto-generated once the templates code is merged?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements feature-flag based Adaptive Telemetry Processor (ATP) integration for dynamic process-level metric filtering in nr-k8s-otel-collector helmchart, following architectural guidance from @pbeckwith.
Changes
Feature Flag Architecture
nrdot_plusconfiguration block with two flags:nrdot_plus.enabled(default:false) - Controls NRDOT Plus collector usagenrdot_plus.atp(default:true) - Controls ATP feature when NRDOT Plus is enabledImage Selection
nrdot_plus.enabledflag:false: Uses standardnewrelic/nrdot-collector-k8s:1.5.0true: Uses NRDOT Plus collectorgmanandhar321/nrdot-collector-host:2.11_images.tplhelper to support both standard and NRDOT Plus image configurationsATP Integration
adaptivetelemetryprocessorconfiguration with:/var/lib/nrdot-collector/adaptivetelemetry.dbattributes/atp_identifierprocessor to tag ATP-processed metricsnrdot_plus.enabled && nrdot_plus.atpPipeline Architecture
Volume Mounts
/var/lib/nrdot-collectoronly created whennrdot_plus.enabled && nrdot_plus.atpLow Data Mode
Configuration Examples
Default (Standard Collector):
NRDOT Plus with ATP::
NRDOT Plus without ATP::
Testing
Outstanding items
var/lib/nrdot-collector. Most likely due to permission issue. Need to debug