More Data added to OHI Inventory #2007
Merged
+354
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13193786760Details
💛 - Coveralls |
rahulreddy15
force-pushed
the
NR-358858-Infra-Agent-add-additional-OHI-details-into-the-inventory
branch
from
2f53613 to
0c44e3b
Compare
Comment on lines
704
to
708
| if expectedValue, exists := expectedLabelValues[id]; exists { | ||
| c.Assert(value, Equals, expectedValue) | ||
| } |
There was a problem hiding this comment.
Can we add a fail if it doesn't exist?
if expectedValue, exists := expectedLabelValues[id]; exists {
c.Assert(value, Equals, expectedValue)
} else {
c.Fail()
}There was a problem hiding this comment.
Test now fails when label is not found.
Comment on lines
1621
to
1627
| if expectedValue, exists := expectedLabelValues[id]; exists { | ||
| assert.EqualValues(t, value, expectedValue) | ||
| } |
There was a problem hiding this comment.
I would add an assertion to fail if expectedValue doesn't exist
if expectedValue, exists := expectedLabelValues[id]; exists {
assert.EqualValues(t, value, expectedValue)
} else {
t.Fail()
}There was a problem hiding this comment.
Test now fails when label is not found.
Comment on lines
1644
to
1653
| if expectedValue, exists := expectedLabelValues[id]; exists { | ||
| assert.EqualValues(t, value, expectedValue) | ||
| } | ||
| } |
There was a problem hiding this comment.
Same as above:
if expectedValue, exists := expectedLabelValues[id]; exists {
assert.EqualValues(t, value, expectedValue)
} else {
t.Fail()
}There was a problem hiding this comment.
Test now fails when label is not found.
integrationVersion, integrationName, reportingAgent added custom attributes from infra agent config are added with prefix labels/ labels from ohi config file are added with prefix labels/
rahulreddy15
force-pushed
the
NR-358858-Infra-Agent-add-additional-OHI-details-into-the-inventory
branch
from
8775e7f to
116b27d
Compare
rahulreddy15
deleted the
NR-358858-Infra-Agent-add-additional-OHI-details-into-the-inventory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integrationVersion, integrationName, reportingAgent added to inventory
custom_attributesfrom infra agent config are added with prefixlabels/labelsfrom ohi config file are added with prefixlabels/