Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: skip tags when synchronizing buckets #2008

Merged
merged 1 commit into from
Jan 29, 2025
Merged

ci: skip tags when synchronizing buckets #2008

merged 1 commit into from
Jan 29, 2025

Conversation

rubenruizdegauna
Copy link
Collaborator

@rubenruizdegauna rubenruizdegauna commented Jan 27, 2025 •
edited
Loading

Copying from main S3 requires having GetObjectTagging permission over the main S3. Instead, we'll copy the objects without tags.

@rubenruizdegauna rubenruizdegauna requested a review from a team as a code owner January 27, 2025 15:48
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12992780403

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 57.332%
Files with Coverage Reduction New Missed Lines %
internal/agent/event_sender.go 1 78.11%
pkg/config/config.go 2 70.63%
pkg/metrics/sampler/sampler_routine.go 2 95.35%
internal/integrations/v4/testhelp/testemit/testemit.go 2 90.63%
Totals Coverage Status
Change from base Build 12947586924: -0.02%
Covered Lines: 15369
Relevant Lines: 26807
💛 - Coveralls

rajrohanyadav
rajrohanyadav approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@rajrohanyadav rajrohanyadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rubenruizdegauna rubenruizdegauna merged commit e9ea741 into master Jan 29, 2025
24 checks passed
@rubenruizdegauna rubenruizdegauna deleted the ci_automate_s3_staging_bucket branch January 29, 2025 11:38
rubenruizdegauna added a commit that referenced this pull request Jan 30, 2025
@rubenruizdegauna
ci: skip tags when synchronizing buckets (#2008)
fa86e5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajrohanyadav rajrohanyadav rajrohanyadav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rubenruizdegauna @coveralls @rajrohanyadav