Skip to content

Allow Linux process command names longer than 15 chars #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lewisdoesstuff wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow Linux process command names longer than 15 chars #2062

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion pkg/metrics/process/snapshot_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"fmt"
"io/ioutil"
"os"
"path/filepath"
"runtime"
"strconv"
"strings"
Expand Down Expand Up @@ -334,7 +335,22 @@ func (pw *linuxProcess) VmSize() int64 {
}

func (pw *linuxProcess) Command() string {
return pw.stats.command
// `comm` values in Linux are limited to TASK_COMM_LEN (16) chars (inc. null byte),
// if it's shorter than that, return the value from /proc/<pid>/stat
// Reading the link requires read permissions on the executable,
// so this is only available when running as root.
if len(pw.stats.command) < 15 || !pw.privileged {
return pw.stats.command
}

// Otherwise, read the link of /proc/<pid>/exe and return the base name
exePath, err := pw.process.Exe()
if err != nil {
return pw.stats.command
}

exeName := filepath.Base(exePath)
return exeName
}

//////////////////////////
Expand Down