fix: prevent cross-type canary pairing in Windows alerts (NR-530959)#2215
Merged
aryamankohli merged 1 commit intomasterfrom Apr 13, 2026
Merged
fix: prevent cross-type canary pairing in Windows alerts (NR-530959)#2215aryamankohli merged 1 commit intomasterfrom
aryamankohli merged 1 commit intomasterfrom
Conversation
Windows canary alerts were incorrectly comparing A2Q canaries with normal canaries due to missing type check in fetch_instances.sh. Added A2Q type validation to ensure current and previous instances are of the same canary type before creating alert pairs.
Pull Request Test Coverage Report for Build 24026741582Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows canary alerts were incorrectly comparing A2Q canaries with normal canaries due to missing type check in fetch_instances.sh. Added A2Q type validation to ensure current and previous instances are of the same canary type before creating alert pairs.