feat: exclude system namespaces from webhook interception#524
Open
kondracek-nr wants to merge 1 commit intomainfrom
Open
feat: exclude system namespaces from webhook interception#524kondracek-nr wants to merge 1 commit intomainfrom
kondracek-nr wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
=======================================
Coverage 68.74% 68.74%
=======================================
Files 53 53
Lines 3513 3513
=======================================
Hits 2415 2415
Misses 863 863
Partials 235 235 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kondracek-nr
force-pushed
the
kondracek/exclude-ns
branch
from
c2b71cc to
8fdb5ae
Compare
kondracek-nr
changed the title
kondracek-nr
force-pushed
the
kondracek/exclude-ns
branch
from
8fdb5ae to
b8e4afe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Customers have noticed that gke complains about k8s-agents-operator intercepting pods in the kube-system namespace.
This change ignores 3 common k8s namespaces that shouldn't be of interest to customers, APM-wise. Users can add more namespaces to this list if they wish, or remove namespaces if they've deployed an app into one of them for some reason, which would be unusual.
Note that this is separate functionality from the user setting the
namespaceLabelSelectorin their instrumentation yaml. Before this change, thempodwebhook intercepted pods in every namespace and then used thenamespaceLabelSelector(when indicated) from the customer-provided instrumentation yaml to decide whether to mutate the pod. This change prevents the webhook from intercepting pods in the ignored namespaces at all.Type of change
Checklist: