chore: add container security context to admission webhook jobs#619
Merged
kondracek-nr merged 1 commit intomainfrom May 15, 2025
Merged
chore: add container security context to admission webhook jobs#619kondracek-nr merged 1 commit intomainfrom
kondracek-nr merged 1 commit intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #619 +/- ##
=======================================
Coverage 51.61% 51.61%
=======================================
Files 3 3
Lines 279 279
=======================================
Hits 144 144
Misses 127 127
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
89ba7b2 to
1ce1b73
Compare
Contributor
|
Should we also add podSecurityContext since we're here already? |
danielstokes
approved these changes
May 15, 2025
Contributor
Author
|
@dbudziwojskiNR podSecurityContext is already hardcoded on these jobs: |
Contributor
Whoops, missed that somehow. We could move that into the values file potentially but I think that out of scope for this PR. LGTM |
dbudziwojskiNR
approved these changes
May 15, 2025
kondracek-nr
added a commit
to dpacheconr/k8s-metadata-injection
that referenced
this pull request
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A customer recently reported that
allowPrivilegeEscalation=falsewasn't working on the admission webhooks in k8s-metadata-injection. This change allowscontainerSecurityContextto be passed into the admission webhook job templates as it is in the deployment.Logs look normal & metadata is added to new pods as expected
Type of change
Checklist: