Draft
Conversation
…Account Enables the webhook job ServiceAccount to inherit global.serviceAccount.annotations, which is critical for IAM role integration in cloud environments: - IRSA (AWS EKS) - Workload Identity (GCP GKE) - Pod Identity (Azure AKS) The ServiceAccount template now includes the common-library helper for annotations, properly merging global annotations with the existing helm hook annotations. Changes: - Add serviceAccount.annotations inheritance to job-patch/serviceaccount.yaml - Add test suite for serviceAccount annotations inheritance - Fix pre-existing test error (notExists -> isNull in webhook_test.yaml) Test Coverage: - Global annotations inheritance validated - Annotation merge behavior with helm hooks validated - All 62 tests passing (10 test suites)
- Add global-inheritance_test.yaml with 20 tests covering cluster, labels, podLabels, images.registry, images.pullSecrets, priorityClassName, hostNetwork, dnsConfig, nodeSelector, and affinity - Add serviceaccount-global_test.yaml with 4 tests for serviceAccount.create - All 15 applicable global values now have explicit helm-unittest coverage - Tests verify both inheritance (global applies when local omitted) and precedence (local overrides global when both set) - Test results: 86/86 passing (24 new tests added) - Achieves 100% global values test coverage for this chart
# Conflicts: # CHANGELOG.md
…notations' into fix/global-serviceaccount-annotations
# Conflicts: # CHANGELOG.md # charts/nri-metadata-injection/tests/affinity_test.yaml # charts/nri-metadata-injection/tests/annotations_test.yaml # charts/nri-metadata-injection/tests/dns_config_test.yaml # charts/nri-metadata-injection/tests/images_test.yaml # charts/nri-metadata-injection/tests/labels_test.yaml # charts/nri-metadata-injection/tests/node_selector_test.yaml # charts/nri-metadata-injection/tests/priority_class_test.yaml # charts/nri-metadata-injection/tests/serviceaccount_test.yaml # charts/nri-metadata-injection/tests/tolerations_test.yaml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
=======================================
Coverage 51.93% 51.93%
=======================================
Files 3 3
Lines 233 233
=======================================
Hits 121 121
Misses 107 107
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Checklist: