ci: group required jobs, add alls-green#1590
Conversation
|
The unexpected unit-test failure shows that the all-green thing is working as expected 😄 |
DavSanchez
force-pushed
the
ci/required-jobs
branch
from
dbf3ab4 to
0847e8b
Compare
.github/workflows/push_pr_checks.yml
Outdated
There was a problem hiding this comment.
Was merging push_pr_checks and push_pr_test too much?
There was a problem hiding this comment.
I have merged them in fa81509 (and updated PR description)! Now there's only one alls-green to add to the repo settings.
| - name: Check code formatting | ||
| run: cargo fmt --check | ||
|
|
||
| checks: |
| - release-build | ||
| - unit-docs-onhost-integration | ||
| - test-with-root | ||
| - embedded |
There was a problem hiding this comment.
can we rename also this?
There was a problem hiding this comment.
You mean only the embedded?
| - coverage | ||
| - checks | ||
| - third-party-notices-check | ||
| - fmt |
There was a problem hiding this comment.
can we call them
cargo-fmt
cargo-doc
cargo-clippy
There was a problem hiding this comment.
I have renamed several of the jobs. LMKWYT!
| check-all-green: | ||
| name: 🟢 All required checks and tests pass |
There was a problem hiding this comment.
Do 'Github settings' require the job key or the job name when configuring required jobs? I wonder if it will work well with the emoji 🤔
There was a problem hiding this comment.
Works fine, I remember when adding the third party notices check since it had an emoji as well:
sigilioso
left a comment
sigilioso
left a comment
There was a problem hiding this comment.
Just a question regarding how to set this up. Thanks for taking care! 🚀
3 participants
What this PR does / why we need it
Groups jobs performed for PRs (checks and tests) into a single workflow and adds a final step with alls-green to fail if any of the depending jobs fail. This enables setting only the
alls-greenjob as required in the repo settings, enforcing a certain degree of CI status to merge.Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
docsis aligned with the change.CONTRIBUTING.md.log level guidelines.