Skip to content

fix: onhost canaries#1688

Merged
alvarocabanas merged 2 commits intomainfrom
NR_462588_fix_on_host_canaries
Sep 19, 2025
Merged

fix: onhost canaries#1688
alvarocabanas merged 2 commits intomainfrom
NR_462588_fix_on_host_canaries

Conversation

@alvarocabanas
Copy link
Contributor

@alvarocabanas alvarocabanas commented Sep 16, 2025

  • Add condition to canary alerts to report if no data.
  • Move canary creation after new package is published.
  • Enable process metrics in on host canaries so alerts can report correctly.

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged. You can also add Jira ticket references if appropriate.)

  • fixes #

Special notes for your reviewer

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Provided a meaningful title following conventional commit style.
  • Included a detailed description for the Pull Request.
  • Documentation under docs is aligned with the change.
  • Follows guidelines for Pull Requests in CONTRIBUTING.md.
  • Follows log level guidelines.

@alvarocabanas alvarocabanas requested a review from a team as a code owner September 16, 2025 14:27
@alvarocabanas alvarocabanas changed the title fix: add condition to canary alerts to report if no data and move canary creation after new package is published fix: onhost canaries Sep 16, 2025
Copy link
Contributor

@gsanchezgavier gsanchezgavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Contributor

@sigilioso sigilioso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarocabanas alvarocabanas merged commit 0e3ae39 into main Sep 19, 2025
31 checks passed
@alvarocabanas alvarocabanas deleted the NR_462588_fix_on_host_canaries branch September 19, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants