Skip to content

fix(tests): typo in config and e2e tests#1714

Merged
paologallinaharbur merged 5 commits intomainfrom
fix/remoteConfig
Sep 25, 2025
Merged

fix(tests): typo in config and e2e tests#1714
paologallinaharbur merged 5 commits intomainfrom
fix/remoteConfig

Conversation

@paologallinaharbur
Copy link
Member

@paologallinaharbur paologallinaharbur commented Sep 24, 2025

What this PR does / why we need it

  • There was a dumb typo in a config causing the whole remote config to break
  • the tests did not catch that since they were not actually leveraging the image built

In a follow up task we should add a mechanism to doublecheck that all tests are actually leveraging the dev built

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Provided a meaningful title following conventional commit style.
  • Included a detailed description for the Pull Request.
  • Documentation under docs is aligned with the change.
  • Follows guidelines for Pull Requests in CONTRIBUTING.md.
  • Follows log level guidelines.

@paologallinaharbur paologallinaharbur changed the title fix(debug) fix(tests): typo in config and e2e tests Sep 24, 2025
@paologallinaharbur paologallinaharbur marked this pull request as ready for review September 24, 2025 12:27
@paologallinaharbur paologallinaharbur requested a review from a team as a code owner September 24, 2025 12:27
@paologallinaharbur paologallinaharbur requested a review from a team September 24, 2025 16:58
@paologallinaharbur paologallinaharbur merged commit 8ec42cd into main Sep 25, 2025
52 of 54 checks passed
@paologallinaharbur paologallinaharbur deleted the fix/remoteConfig branch September 25, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments