feat: add new command to migrate onhost folders by vjripoll · Pull Request #1815 · newrelic/newrelic-agent-control

vjripoll · 2025-10-30T10:29:37Z

What this PR does / why we need it

THIESE CHANGES SHOULD BE PLANNED TO BE DELETED IN A NEAR FUTURE

Add new command into the newrelic-agent-control-cli to copy and rename all the old folders from the current installations to the new paths and names, the content is going to be the same

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged. You can also add Jira ticket references if appropriate.)

fixes #

Special notes for your reviewer

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

Provided a meaningful title following conventional commit style.
Included a detailed description for the Pull Request.
Documentation under docs is aligned with the change.
Follows guidelines for Pull Requests in CONTRIBUTING.md.
Follows log level guidelines.

agent-control/src/bin/main_agent_control_onhost_cli.rs

agent-control/src/cli/on_host/migrate_folders.rs

paologallinaharbur

It looks good, only ebpf seems to be missing.

code structure can be improved, but I am not sure if it is worth it considering that it is just a migration tool

agent-control/src/cli/on_host/migrate_folders.rs

danielorihuela

I left nit's. Not sure how worth it is if we plan on removing it long term. Great work!!!

build/package/postinstall.sh

agent-control/src/cli/on_host/migrate_folders.rs

paologallinaharbur · 2025-11-05T07:26:48Z

agent-control/src/cli/on_host/host_monitoring_gen/infra_config_gen.rs

        for (agent_id, _) in sub_agents_cfg.agents {
-            let infra_values_persister =
-                ValuesPersisterFile::new(self.local_dir.join(SUB_AGENT_DIR));
+            let infra_values_persister = ValuesPersisterFile::new(self.local_dir.clone());


is this change belonging to this PR?

paologallinaharbur · 2025-11-05T07:26:53Z

agent-control/src/cli/on_host/host_monitoring_gen/otel_config_gen.rs

-            otel_agent_values_path: PathBuf::from(
-                "/etc/newrelic-agent-control/fleet/agents.d/nrdot/values",
-            ),
+            otel_agent_values_path: PathBuf::from("/etc/newrelic-agent-control/local-data/nrdot"),


same here, isn't related to an other PR?

* feat: new command to migrate old folder to new ones * fix command name and check logic * simplify the check logic to check only for local paths * fix more comments and simplify * move from statics agents names to scrapping fleet/agents.d

* restruture on host folder and names * feat: add new command to migrate onhost folders (#1815) * feat: new command to migrate old folder to new ones * fix command name and check logic * simplify the check logic to check only for local paths * fix more comments and simplify * move from statics agents names to scrapping fleet/agents.d

vjripoll changed the base branch from main to restructure-on-host-folders October 30, 2025 10:30

vjripoll force-pushed the add-new-command-to-migrate-onhost-folders branch 3 times, most recently from 3727632 to c6ceb4a Compare October 31, 2025 10:08

vjripoll marked this pull request as ready for review October 31, 2025 10:30

vjripoll requested a review from a team as a code owner October 31, 2025 10:30

sigilioso reviewed Oct 31, 2025

View reviewed changes

agent-control/src/bin/main_agent_control_onhost_cli.rs Show resolved Hide resolved