Conversation
| Self { | ||
| otel_agent_values_path: PathBuf::from( | ||
| "/etc/newrelic-agent-control/fleet/agents.d/nr-otel-collector/values", | ||
| "/etc/newrelic-agent-control/fleet/agents.d/nrdot/values", |
There was a problem hiding this comment.
All this is a bit fragile , we should use defaults const to improve it a bit
There was a problem hiding this comment.
That's true, and do you want to leave it out of this PR? you can move this to a constant at the top of the file like it's done for infra-agent you can even compose it in 2 :
- /etc/newrelic-agent-control/
- fleet/agents.d/nrdot/values
So it can be matched on the test
There was a problem hiding this comment.
yes i will create a separate pr, try to find find other part like this . I think we can release without that
gsanchezgavier
added
the
onhost-extended-e2e
| Self { | ||
| otel_agent_values_path: PathBuf::from( | ||
| "/etc/newrelic-agent-control/fleet/agents.d/nr-otel-collector/values", | ||
| "/etc/newrelic-agent-control/fleet/agents.d/nrdot/values", |
There was a problem hiding this comment.
That's true, and do you want to leave it out of this PR? you can move this to a constant at the top of the file like it's done for infra-agent you can even compose it in 2 :
- /etc/newrelic-agent-control/
- fleet/agents.d/nrdot/values
So it can be matched on the test
| @@ -1,2 +1,2 @@ | |||
| config: | | |||
| config: | |||
| {{ OTEL_COLLECTOR_CONFIG }} | |||
| LOCAL_PACKAGE_PATH ?= $(CURDIR)/../../dist | ||
| RECIPE_BRANCH ?= main | ||
| RECIPE_BRANCH ?= NR_483970_use_cli_host_monitoring | ||
|
|
There was a problem hiding this comment.
Shouldn't you leave it to main?
There was a problem hiding this comment.
no, main is broken. Once your Pr is merged on the recipe please move this to main
gsanchezgavier
force-pushed
the
gsanchez/test/nrdot-e2e-onhost
branch
from
9cef75f to
0d31841
Compare
2 participants
Fixes nrdot