feat(test): add signatures to oci integration tests [NR-520796]#2212
feat(test): add signatures to oci integration tests [NR-520796]#2212sigilioso wants to merge 1 commit intofreeze-developfrom
Conversation
|
|
||
| retry(60, Duration::from_secs(1), || { | ||
| // Remote config status should fail because the package is unsigned | ||
| check_latest_remote_config_status_is_expected( |
There was a problem hiding this comment.
i think this is how we generally test this cases , but would make sense to specify some expected "partial" log ? i guess that in the future when the error get's typed we will be able to check the types 🤞
There was a problem hiding this comment.
Yeah, I don't like that much that we could have a failed remote config because other reasons. I might be able to check the error message in the remote-config-status. I'll look into it!
| // TODO: this should pass with signatures in place | ||
| #[test] | ||
| #[ignore = "needs oci registry (use *with_oci_registry suffix), needs elevated privileges on Windows"] | ||
| fn test_unsigned_artifact_makes_remote_config_fail_with_oci_registry() { |
There was a problem hiding this comment.
Have you thought about having a test where the verification is disabled?
There was a problem hiding this comment.
Yes, but I'm not sure if they should be at this level (there are too many things moving around). Maybe we can assure that the enable/disable behavior is well covered with unit tests (or integration tests using components).
It is a good point anyway, we can see if we are happy covering it with unit tests with the implementation in place. Thanks!
3 participants
🚧 WIP
Signatures aren't in place yet ❗
Summary
This PR adds signatures to OCI integration tests.