Skip to content

Comments

chore: fix broken gql test service#1498

Merged
metal-messiah merged 1 commit intomainfrom
gql-fix
Jun 10, 2025
Merged

chore: fix broken gql test service#1498
metal-messiah merged 1 commit intomainfrom
gql-fix

Conversation

@metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Jun 10, 2025

Point the graphql tests to our internal testing service with a new mocked endpoint instead of relying on a demo service, which has recently gone down and caused test failures.

Overview

Related Issue(s)

Testing

graphql-metadata.e2e.js should now pass

@github-actions
Copy link

Supportability Metric Usage Changes:

No matching changes found

Supportability Metrics .md File Changes:

supportability_metrics.md was changed? false

New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR.

@github-actions
Copy link

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 24.97 kB / 9.47 kB (gzip) 24.97 kB / 9.47 kB (gzip) 0% / 0% (gzip)
lite async-chunk 52.6 kB / 17.45 kB (gzip) 52.6 kB / 17.45 kB (gzip) 0% / 0% (gzip)
pro loader 52.91 kB / 18.61 kB (gzip) 52.91 kB / 18.61 kB (gzip) 0% / 0% (gzip)
pro async-chunk 92 kB / 28.52 kB (gzip) 92 kB / 28.52 kB (gzip) 0% / 0% (gzip)
spa loader 61.66 kB / 21.31 kB (gzip) 61.66 kB / 21.31 kB (gzip) 0% / 0% (gzip)
spa async-chunk 116.63 kB / 35.49 kB (gzip) 116.63 kB / 35.49 kB (gzip) 0% / 0% (gzip)

@codecov
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (375c37f) to head (f1c90c3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1498   +/-   ##
=======================================
  Coverage   87.61%   87.61%           
=======================================
  Files         197      197           
  Lines        7761     7761           
  Branches     1563     1563           
=======================================
  Hits         6800     6800           
  Misses        826      826           
  Partials      135      135           
Flag Coverage Δ
unit-tests 78.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@metal-messiah
Copy link
Member Author

Copy link
Contributor

@ellisong ellisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metal-messiah metal-messiah merged commit 82b9f78 into main Jun 10, 2025
20 checks passed
@metal-messiah metal-messiah deleted the gql-fix branch June 10, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants