Skip to content

Comments

chore: fix ios test inconsistency#1551

Merged
metal-messiah merged 1 commit intomainfrom
fix-test-issue
Aug 26, 2025
Merged

chore: fix ios test inconsistency#1551
metal-messiah merged 1 commit intomainfrom
fix-test-issue

Conversation

@metal-messiah
Copy link
Member

This PR fixes an issue that causes iOS to fail sporadically due to races between the mobile container and the window being ready to receive commands compared to other browsers.

Overview

Related Issue(s)

Testing

@github-actions
Copy link

Supportability Metric Usage Changes:

No matching changes found

Supportability Metrics .md File Changes:

supportability_metrics.md was changed? false

New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR.

@github-actions
Copy link

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 25.9 kB / 9.76 kB (gzip) 25.9 kB / 9.76 kB (gzip) 0% / 0% (gzip)
lite async-chunk 54.49 kB / 18.02 kB (gzip) 54.49 kB / 18.02 kB (gzip) 0% / 0% (gzip)
pro loader 54.02 kB / 19.03 kB (gzip) 54.02 kB / 19.03 kB (gzip) 0% / 0% (gzip)
pro async-chunk 92.76 kB / 28.7 kB (gzip) 92.76 kB / 28.7 kB (gzip) 0% / 0% (gzip)
spa loader 62.78 kB / 21.74 kB (gzip) 62.78 kB / 21.74 kB (gzip) 0% / 0% (gzip)
spa async-chunk 117.34 kB / 35.68 kB (gzip) 117.34 kB / 35.68 kB (gzip) 0% / 0% (gzip)

@codecov
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.67%. Comparing base (58f3c52) to head (aca71fd).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1551   +/-   ##
=======================================
  Coverage   87.67%   87.67%           
=======================================
  Files         201      201           
  Lines        7771     7771           
  Branches     1582     1582           
=======================================
  Hits         6813     6813           
  Misses        825      825           
  Partials      133      133           
Flag Coverage Δ
unit-tests 79.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@metal-messiah
Copy link
Member Author

Copy link
Contributor

@cwli24 cwli24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this really work? lol

@metal-messiah metal-messiah merged commit b9d2401 into main Aug 26, 2025
19 checks passed
@metal-messiah metal-messiah deleted the fix-test-issue branch August 26, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants