Skip to content

feat: Reduce hasReplay attribute false positive rate#1586

Merged
metal-messiah merged 1 commit intomainfrom
has-replay-flag-pve
Oct 9, 2025
Merged

feat: Reduce hasReplay attribute false positive rate#1586
metal-messiah merged 1 commit intomainfrom
has-replay-flag-pve

Conversation

@metal-messiah
Copy link
Member

Only set "hasReplay" attribute once a successful session replay harvest has been observed to help reduce false positives.

Overview

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-475215

Testing

@metal-messiah metal-messiah changed the title feat: hasReplay only to be set when a previous session replay harvest has happened feat: Reduce hasReplay attribute false positive rate Oct 9, 2025
@github-actions
Copy link

github-actions bot commented Oct 9, 2025

Supportability Metric Usage Changes:

No matching changes found

Supportability Metrics .md File Changes:

supportability_metrics.md was changed? false

New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR.

@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.16%. Comparing base (d38e8b9) to head (88ab2b8).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1586   +/-   ##
=======================================
  Coverage   88.16%   88.16%           
=======================================
  Files         205      205           
  Lines        7856     7857    +1     
  Branches     1607     1607           
=======================================
+ Hits         6926     6927    +1     
  Misses        806      806           
  Partials      124      124           
Flag Coverage Δ
unit-tests 81.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Oct 9, 2025

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 26.08 kB / 9.85 kB (gzip) 26.08 kB / 9.85 kB (gzip) 0% / 0.05% (gzip)
lite async-chunk 55.82 kB / 18.4 kB (gzip) 55.87 kB / 18.42 kB (gzip) 0.08% / 0.08% (gzip)
pro loader 54.82 kB / 19.28 kB (gzip) 54.82 kB / 19.28 kB (gzip) 0% / -0.02% (gzip)
pro async-chunk 94.82 kB / 29.5 kB (gzip) 94.87 kB / 29.51 kB (gzip) 0.05% / 0.04% (gzip)
spa loader 63.67 kB / 21.99 kB (gzip) 63.67 kB / 21.99 kB (gzip) 0% / 0% (gzip)
spa async-chunk 120.47 kB / 36.78 kB (gzip) 120.51 kB / 36.79 kB (gzip) 0.04% / 0.04% (gzip)

@github-actions
Copy link

github-actions bot commented Oct 9, 2025

Static Badge

Last ran on October 09, 2025 11:42:37 CDT
Checking merge of (88ab2b8) into main (d38e8b9)

@metal-messiah metal-messiah merged commit 82f1d55 into main Oct 9, 2025
34 of 35 checks passed
@metal-messiah metal-messiah deleted the has-replay-flag-pve branch October 9, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants