Skip to content

chore: centralize NPM behaviors to a single shared workflow#1604

Merged
metal-messiah merged 3 commits intomainfrom
npm-consolidation
Oct 29, 2025
Merged

chore: centralize NPM behaviors to a single shared workflow#1604
metal-messiah merged 3 commits intomainfrom
npm-consolidation

Conversation

@metal-messiah
Copy link
Member

Update the repo to centralize all workflows that hit NPM to use a single shared workflow to support OIDC trusted publishing requirements.

Overview

Related Issue(s)

Testing

@github-actions
Copy link

Supportability Metric Usage Changes:

No matching changes found

Supportability Metrics .md File Changes:

supportability_metrics.md was changed? false

New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR.

@github-actions
Copy link

github-actions bot commented Oct 24, 2025

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 25.96 kB / 9.8 kB (gzip) 25.96 kB / 9.8 kB (gzip) 0% / 0% (gzip)
lite async-chunk 53.13 kB / 17.72 kB (gzip) 53.13 kB / 17.72 kB (gzip) 0% / 0% (gzip)
pro loader 54.48 kB / 19.27 kB (gzip) 54.48 kB / 19.27 kB (gzip) 0% / 0% (gzip)
pro async-chunk 91.8 kB / 28.82 kB (gzip) 91.8 kB / 28.82 kB (gzip) 0% / 0% (gzip)
spa loader 63.28 kB / 21.95 kB (gzip) 63.28 kB / 21.95 kB (gzip) 0% / 0% (gzip)
spa async-chunk 117.21 kB / 36.11 kB (gzip) 117.21 kB / 36.11 kB (gzip) 0% / 0% (gzip)

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.60%. Comparing base (3b787b0) to head (984612d).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1604   +/-   ##
=======================================
  Coverage   88.60%   88.60%           
=======================================
  Files         206      206           
  Lines        7746     7751    +5     
  Branches     1584     1588    +4     
=======================================
+ Hits         6863     6868    +5     
  Misses        772      772           
  Partials      111      111           
Flag Coverage Δ
unit-tests 81.87% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@metal-messiah
Copy link
Member Author

tested manually with the prerelease workflow in dryrun mode https://github.com/newrelic/newrelic-browser-agent/actions/runs/18787081555/job/53607966077

Copy link
Contributor

@ellisong ellisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Copy link
Contributor

@ellisong ellisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after I understood why we don't need npm auth. We're moving to OIDC.

@metal-messiah metal-messiah merged commit 09ff9b3 into main Oct 29, 2025
18 checks passed
@metal-messiah metal-messiah deleted the npm-consolidation branch October 29, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants