feat: SMs for browser connect response#1611
Merged
Conversation
Supportability Metric Usage Changes:No matching changes found Supportability Metrics .md File Changes:supportability_metrics.md was changed? New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR. |
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1611 +/- ##
==========================================
- Coverage 88.60% 88.52% -0.08%
==========================================
Files 206 206
Lines 7746 7753 +7
Branches 1586 1587 +1
==========================================
Hits 6863 6863
- Misses 772 778 +6
- Partials 111 112 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
metal-messiah
approved these changes
Oct 31, 2025
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds supportability metrics for failed responses on initializing the page_view_event aggregate.
Overview
Adds supportability metrics for failed responses from the browser connect service. We use this response to initialize our page view event feature as well as to know what aggregate features to start up for our remaining features. Any response that isn't a successful status code (>= http 400) will emit the following support metrics:
Browser/Supportability/BCS/Error/StatusCodeBrowser/Supportability/BCS/Error/Dropped/BytesBrowser/Supportability/BCS/Error/Duration/MsRelated Issue(s)
JIRA: https://new-relic.atlassian.net/browse/NR-428192
Testing
Make sure WDIO tests pass.
Locally testing this outside WDIO is difficult since it requires getting an external service to intentionally fail its requests.