Skip to content

Comments

chore: Explicitly grant write in release please#1617

Merged
ptang-nr merged 1 commit intomainfrom
update-release-please-workflow
Nov 4, 2025
Merged

chore: Explicitly grant write in release please#1617
ptang-nr merged 1 commit intomainfrom
update-release-please-workflow

Conversation

@ptang-nr
Copy link
Contributor

@ptang-nr ptang-nr commented Nov 4, 2025

Bump token used in release please workflow

Overview

Sample error message

Invalid workflow file: .github/workflows/release-please.yml#L35 
The workflow is not valid. .github/workflows/release-please.yml (Line: 35, Col: 3): 
Error calling workflow 'newrelic/newrelic-browser-agent/.github/workflows/npm-operations.yml@<commit_id>'. 
The workflow is requesting 'id-token: write', but is only allowed 'id-token: none'.

Related Issue(s)

Testing

Sample error message -
Invalid workflow file: .github/workflows/release-please.yml#L35
The workflow is not valid. .github/workflows/release-please.yml (Line: 35, Col: 3): Error calling workflow 'newrelic/newrelic-browser-agent/.github/workflows/npm-operations.yml@<commit_id>'. The workflow is requesting 'id-token: write', but is only allowed 'id-token: none'.
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Supportability Metric Usage Changes:

No matching changes found

Supportability Metrics .md File Changes:

supportability_metrics.md was changed? false

New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR.

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 25.96 kB / 9.8 kB (gzip) 25.96 kB / 9.8 kB (gzip) 0% / 0% (gzip)
lite async-chunk 53.84 kB / 18.05 kB (gzip) 53.84 kB / 18.05 kB (gzip) 0% / 0% (gzip)
pro loader 54.39 kB / 19.23 kB (gzip) 54.39 kB / 19.23 kB (gzip) 0% / 0% (gzip)
pro async-chunk 92.49 kB / 29 kB (gzip) 92.49 kB / 29 kB (gzip) 0% / 0% (gzip)
spa loader 63.24 kB / 21.92 kB (gzip) 63.24 kB / 21.92 kB (gzip) 0% / 0% (gzip)
spa async-chunk 117.9 kB / 36.32 kB (gzip) 117.9 kB / 36.32 kB (gzip) 0% / 0% (gzip)

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.51%. Comparing base (23cb559) to head (a45e161).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1617   +/-   ##
=======================================
  Coverage   88.51%   88.51%           
=======================================
  Files         206      206           
  Lines        7760     7760           
  Branches     1591     1591           
=======================================
  Hits         6869     6869           
  Misses        779      779           
  Partials      112      112           
Flag Coverage Δ
unit-tests 81.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ptang-nr ptang-nr marked this pull request as ready for review November 4, 2025 20:00
@ptang-nr ptang-nr merged commit 73d131d into main Nov 4, 2025
19 checks passed
@ptang-nr ptang-nr deleted the update-release-please-workflow branch November 4, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants