Skip to content

feat(dashboard): support multiple account id's when creating dashboards#1319

Merged
vinay-newrelic merged 1 commit intomainfrom
NR-436500
Jul 29, 2025
Merged

feat(dashboard): support multiple account id's when creating dashboards#1319
vinay-newrelic merged 1 commit intomainfrom
NR-436500

Conversation

@vinay-newrelic
Copy link
Contributor

@vinay-newrelic vinay-newrelic commented Jul 14, 2025

https://new-relic.atlassian.net/browse/NR-436500

problem context:
After the multiple account query was launched, the backend system in New Relic platform got be able to respond the JSON file supporting the multiple account data. Once, however, newrelic-cli makes a Terraform formatted file, its output doesn't contain the information on the part of multiple account (losing or trimmed this kind of information). It resulted in different output of dashboards or sometimes the series of provisioning doesn't work as expected.

As tentative solution for this, the customer needs to manually create the dashboard. This is very laborious to do the flow and can potentially include some kind of human error.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2025

Codecov Report

Attention: Patch coverage is 46.59091% with 47 lines in your changes missing coverage. Please review.

Project coverage is 35.66%. Comparing base (edd551c) to head (655ccb9).

Files with missing lines Patch % Lines
internal/http/client.go 50.00% 25 Missing and 3 partials ⚠️
pkg/config/config.go 30.76% 9 Missing ⚠️
internal/http/request.go 52.94% 7 Missing and 1 partial ⚠️
newrelic/newrelic.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1319      +/-   ##
==========================================
- Coverage   35.72%   35.66%   -0.07%     
==========================================
  Files         133      133              
  Lines        7865     7930      +65     
==========================================
+ Hits         2810     2828      +18     
- Misses       4862     4905      +43     
- Partials      193      197       +4     
Flag Coverage Δ
unit 35.66% <46.59%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vinay-newrelic vinay-newrelic force-pushed the NR-436500 branch 2 times, most recently from 655ccb9 to b04229b Compare July 20, 2025 20:17
@vinay-newrelic vinay-newrelic merged commit de92725 into main Jul 29, 2025
13 of 14 checks passed
@vinay-newrelic vinay-newrelic deleted the NR-436500 branch July 29, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments